Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor project updates #2040

Merged
merged 5 commits into from
Feb 26, 2025
Merged

Minor project updates #2040

merged 5 commits into from
Feb 26, 2025

Conversation

stephprince
Copy link
Contributor

@stephprince stephprince commented Feb 25, 2025

Motivation

Minor updates to fix build errors in the run all tests GH action and to apply the upper bound to hdmf that was discussed in #2030 (comment)

These changes are intended to be merged into the release-3.0.0 branch.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff check . && codespell from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.84%. Comparing base (9d7bad1) to head (abeeeec).
Report is 1 commits behind head on release-3.0.0.

Additional details and impacted files
@@              Coverage Diff               @@
##           release-3.0.0    #2040   +/-   ##
==============================================
  Coverage          92.84%   92.84%           
==============================================
  Files                 28       28           
  Lines               2755     2755           
  Branches             716      716           
==============================================
  Hits                2558     2558           
  Misses               127      127           
  Partials              70       70           
Flag Coverage Δ
integration 73.72% <ø> (ø)
unit 82.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephprince stephprince marked this pull request as ready for review February 26, 2025 19:16
@stephprince stephprince requested a review from rly February 26, 2025 19:18
@stephprince
Copy link
Contributor Author

@rly I think readthedocs is flaky at the moment and I don't think the failing link check is related to this PR

@stephprince stephprince merged commit 2a2e7ff into release-3.0.0 Feb 26, 2025
23 of 25 checks passed
@stephprince stephprince deleted the minor-project-updates branch February 26, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants