-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ImagingPlane.description optional #2051
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2051 +/- ##
=======================================
Coverage 92.84% 92.84%
=======================================
Files 28 28
Lines 2755 2755
Branches 716 716
=======================================
Hits 2558 2558
Misses 127 127
Partials 70 70
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
## [Upcoming] | ||
|
||
### Bug fixes | ||
- Made `ImagingPlane.description` optional to conform with the NWB Schema. Note that if you use positional arguments to create |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change since the order of positional arguments was changed, correct?
Would it be better to take the approach that was used in add_electrode
to prevent breaking changes until positional arguments are deprecated in the next major release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is the better approach. I'll update the PR
Motivation
Fix #2049
Checklist
ruff check . && codespell
from the source directory.