Skip keys that are not meant to be references #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @NickSdot
you pinged me in cebe#156 (comment). I know, it has been a while since then, but the urge to dive into the topic again wasn't that big, to be honest.
Once again I'm now at the good old problem that we can't update the package, so I'll give it another try. I tried your suggested performance fix, and it works 🎉. Well done!
I found this little bug, though, that
resolveRelativeUri()
is called also on values that are not meant to be URIs. I guess this was unintentionally introduced when trying to DRY the code by combiningbefore
So this PR fixes that