WIP: python3Packages.load_libstdcxx: init at 0.0.1 #224686
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
SomeoneSerge
commented
Apr 4, 2023
| // E.g. earlier we've observed the combination of [ "torch" "zmq" ] fail | ||
| // because of std::condition_variable | ||
| m.def("dummy", []() { | ||
| // Copy-pasted from |
There was a problem hiding this comment.
Actually, this is very stupid. We need a reliable way to ask for specific symbols, and we need an automatic update script for this derivation: e.g. one that objdumps the current libstdcxx, sorts symbols by versions, and takes the newest stuff.
On that note, I should rework tests.loadOld. The fact that it works right now is sheer accident
ofborg
bot
requested review from
teh,
thoughtpolice,
tscholak,
abbradar,
mdaiter and
samuela
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
A helper for verifying that python packages built with a non-standard stdenv (e.g. cuda-enabled packages overriding the stdenv to satisfy nvcc) do not cause libstdc++ mismatch errors at runtime. Just append this module to
pythonImportsCheck