Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs_22: 22.11.0 -> 22.12.0 #361565

Merged
merged 1 commit into from
Dec 25, 2024
Merged

nodejs_22: 22.11.0 -> 22.12.0 #361565

merged 1 commit into from
Dec 25, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Dec 3, 2024 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Scrumplex
Scrumplex approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nodejs_22 builds when rebased onto staging-next

@aduh95 aduh95 mentioned this pull request Dec 18, 2024
Closed
13 tasks
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 19, 2024
@aduh95 aduh95 force-pushed the nodejs_22 branch 2 times, most recently from 24d4b6c to c70c610 Compare December 20, 2024 00:26
@aduh95
Copy link
Contributor Author

aduh95 commented Dec 20, 2024

I've removed the shared SQLite revert and instead enabled the required sqlite features as documented in nodejs/node#56318.

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 20, 2024
Scrumplex
Scrumplex approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nodejs_22 and all its tests build on x86_64-linux.

I rebased HEAD^ on staging-next

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 20, 2024
@aduh95 aduh95 added backport staging-24.11 Backport PR automatically and removed backport release-24.05 backport release-24.11 Backport PR automatically labels Dec 20, 2024
@ofborg ofborg bot added the 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild label Dec 20, 2024
@ofborg ofborg bot requested a review from np December 20, 2024 20:45
@dasJ dasJ merged commit e4f4440 into NixOS:staging Dec 25, 2024
52 of 53 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 25, 2024

Backport failed for staging-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin staging-24.11
git worktree add -d .worktree/backport-361565-to-staging-24.11 origin/staging-24.11
cd .worktree/backport-361565-to-staging-24.11
git switch --create backport-361565-to-staging-24.11
git cherry-pick -x e4f44407a7a9a5561cd6b589a6d27e7a8f91a720

@aduh95 aduh95 deleted the nodejs_22 branch December 26, 2024 00:33
aduh95 added a commit to aduh95/nixpkgs that referenced this pull request Dec 26, 2024
@aduh95
nodejs_22: 22.11.0 -> 22.12.0 (NixOS#361565)
667f7d3 
(cherry picked from commit e4f4440)
aduh95 added a commit to aduh95/nixpkgs that referenced this pull request Dec 26, 2024
@aduh95
nodejs_22: 22.11.0 -> 22.12.0 (NixOS#361565)
685e9a2 
(cherry picked from commit e4f4440)
aduh95 added a commit to aduh95/nixpkgs that referenced this pull request Dec 26, 2024
@aduh95
nodejs_22: 22.11.0 -> 22.12.0 (NixOS#361565)
c0aa66f 
(cherry picked from commit e4f4440)
aduh95 added a commit to aduh95/nixpkgs that referenced this pull request Dec 26, 2024
@aduh95
nodejs_22: 22.11.0 -> 22.12.0 (NixOS#361565)
284f82c 
(cherry picked from commit e4f4440)
emilazy pushed a commit to emilazy/nixpkgs that referenced this pull request Jan 5, 2025
@aduh95 @emilazy
nodejs_22: 22.11.0 -> 22.12.0 (NixOS#361565)
6f18fb0 
(cherry picked from commit e4f4440)
emilazy pushed a commit to emilazy/nixpkgs that referenced this pull request Jan 5, 2025
@aduh95 @emilazy
nodejs_22: 22.11.0 -> 22.12.0 (NixOS#361565)
598874d 
(cherry picked from commit e4f4440)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scrumplex Scrumplex Scrumplex approved these changes

@np np Awaiting requested review from np

Assignees
No one assigned
Labels
6.topic: nodejs 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person backport staging-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @Scrumplex @dasJ @wegank