Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-asm: remove #377077

Merged
merged 1 commit into from
Jan 29, 2025
Merged

cargo-asm: remove #377077

merged 1 commit into from
Jan 29, 2025

Conversation

alyssais
Copy link
Member

6 years since the last upstream commit. Lockfile is too old for fetchCargoVendor.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 26, 2025
@emilazy
Copy link
Member

emilazy commented Jan 26, 2025

I actually used this back in the day, but it looks like cargo-show-asm is the maintained successor, and we have that packaged. Could you mention it in the throw? cf. gnzlbg/cargo-asm#244

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jan 27, 2025
6 years since the last upstream commit.  Lockfile is too old for
fetchCargoVendor.
@alyssais alyssais merged commit 2f5582c into NixOS:master Jan 29, 2025
25 of 27 checks passed
@alyssais alyssais deleted the cargo-asm-remove branch January 29, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants