Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broken indentation in generated TS definitions docs #1188

Closed
OmarTawfik opened this issue Dec 12, 2024 · 0 comments · Fixed by #1225
Closed

broken indentation in generated TS definitions docs #1188

OmarTawfik opened this issue Dec 12, 2024 · 0 comments · Fixed by #1225
Assignees
@mjoerussell

Comments

@OmarTawfik
Copy link
Contributor

@OmarTawfik: the indentation is broken here, but not in cst.wit. I wonder if this is a jco bug?

@mjoerussell: Not jco itself, but it seems like wit-parser strips whitespace from doc comments.

@OmarTawfik: In that case, I suggest submitting a PR or an issue at wit-parser. It might be easier to fix there than trying to find a workaround on our side.
It is owned by the same org that maintains jco, and we might be able to get a quick turnaround there.

Originally posted by @OmarTawfik in #1169 (comment)
@OmarTawfik OmarTawfik mentioned this issue Dec 12, 2024
Merged
2 tasks
@mjoerussell mjoerussell mentioned this issue Jan 21, 2025
Merged
@github-project-automation github-project-automation bot moved this to ⏳ Todo in Slang - 2025 Feb 5, 2025
@OmarTawfik OmarTawfik changed the title broken indentation in generated TS definitions dpoc broken indentation in generated TS definitions docs Feb 18, 2025
github-merge-queue bot pushed a commit that referenced this issue Feb 21, 2025
@mjoerussell
Fix whitespace in generated Wit interfaces (#1225)
429f696 
This PR updates our version of jco so that we can integrate [this fix
from
wasm-tools](bytecodealliance/wasm-tools#1954).

Closes #1188

---------

Co-authored-by: github-actions <[email protected]>
@github-project-automation github-project-automation bot moved this from ⏳ Todo to ✅ Done in Slang - 2025 Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjoerussell mjoerussell

Labels
None yet
Projects
Slang - 2025
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix whitespace in generated Wit interfaces manastech/slang
2 participants
@OmarTawfik @mjoerussell