fix: look for attachment: in file upload source
#613
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @mfts, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request addresses an issue where Notion file uploads now append attachment: to the file identifier instead of the S3 URL. The change modifies the NotionAPI class in packages/notion-client/src/notion-api.ts to recognize attachment: as a valid source for file uploads, in addition to the existing secure.notion-static.com and prod-files-secure sources.
Highlights
- Bug Fix: The pull request fixes an issue where file uploads from Notion were not correctly identified due to a change in the file identifier format.
- File Source Recognition: The code now recognizes
attachment:as a valid source for file uploads, ensuring that files from Notion are correctly processed.
Changelog
- packages/notion-client/src/notion-api.ts
- Modified the
NotionAPIclass to includeattachment:as a valid source for file uploads. - Updated the source check to include
source.includes('attachment:').
- Modified the
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Did you know?
The .ts file extension stands for TypeScript.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request introduces a fix to the Notion client to correctly identify file uploads that use the attachment: prefix instead of the S3 URL. This ensures that the client can properly handle these files. The change is straightforward and addresses a specific issue.
Merge Readiness
The code change is a small but important fix. Given the straightforward nature of the change and the absence of any identified issues at the medium, high, or critical severity levels, the pull request appears ready for merging. However, I am unable to directly approve the pull request, and it should be reviewed and approved by others before merging.
|
Thanks @marc 🙏 |
Description
Notion file uploads now append
attachment:to the file identifier instead of the s3 url.Therefore the source is also a valid source if it includes
attachment:in the source text.Notion Test Page ID
Here's an example of a Notion page
1b2d3f870f0080caae0bc0b2766cf31f