fix(eslint): imports sort lint #614
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @nightohl, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request addresses an issue where the eslint check for sorting import order was missed in a previous PR (#609). The changes involve reordering the imports in packages/react-notion-x/src/components/text.tsx to comply with the eslint rules.
Highlights
- Eslint Fix: The primary focus is to fix the import order in
packages/react-notion-x/src/components/text.tsxto align with eslint's import sorting rules. - Import Reordering: The
LinkMentionimport was moved above thePageTitleimport inpackages/react-notion-x/src/components/text.tsx.
Changelog
- packages/react-notion-x/src/components/text.tsx
- Reordered imports to satisfy eslint's import sorting rules. Specifically,
LinkMentionwas moved abovePageTitle.
- Reordered imports to satisfy eslint's import sorting rules. Specifically,
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
The linter's watchful eye,
Catches imports that fly,
Out of order, they stray,
Till a PR saves the day.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request aims to fix the import order in text.tsx to align with the project's linting rules. This is a necessary step to ensure code consistency and maintainability. The change itself is straightforward, involving reordering the import statements.
Merge Readiness
The pull request addresses a specific linting issue and the change is localized. Given the straightforward nature of the fix, the pull request appears to be ready for merging. However, it's advisable to ensure that the linting rules are consistently applied across the entire project to prevent similar issues in the future. I am unable to approve the pull request, and users should have others review and approve this code before merging.
|
no worries :) |
Description
@transitive-bullshit Thanks for merging my PR!
but It seems I missed running the eslint check for sorting import order. This PR is to fix that so it can pass the merge process.
Also, I'm gonna update the contribution guide and add a lint check to the GitHub Actions for PRs and pushes, and submit a new PR for that as well.
Notion Test Page ID