PR feedback

NuGet · Dec 22, 2020 · a6fc680 · a6fc680
1 parent b3f8d3b
commit a6fc680
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/src/NuGet.Clients/NuGet.VisualStudio.Common/Telemetry/INuGetTelemetryProvider.cs b/src/NuGet.Clients/NuGet.VisualStudio.Common/Telemetry/INuGetTelemetryProvider.cs
@@ -11,7 +11,7 @@ namespace NuGet.VisualStudio.Telemetry
 {
     public interface INuGetTelemetryProvider
     {
-        Task EmitEventAsync(TelemetryEvent telemetryEvent);
+        void EmitEvent(TelemetryEvent telemetryEvent);
         Task PostFaultAsync(Exception e, string callerClassName, [CallerMemberName] string callerMemberName = null, IDictionary<string, object> extraProperties = null);
         void PostFault(Exception e, string callerClassName, [CallerMemberName] string callerMemberName = null, IDictionary<string, object> extraProperties = null);
     }

diff --git a/src/NuGet.Clients/NuGet.VisualStudio.Common/Telemetry/NuGetTelemetryProvider.cs b/src/NuGet.Clients/NuGet.VisualStudio.Common/Telemetry/NuGetTelemetryProvider.cs
@@ -13,10 +13,9 @@ namespace NuGet.VisualStudio.Telemetry
     [Export(typeof(INuGetTelemetryProvider))]
     internal class NuGetTelemetryProvider : INuGetTelemetryProvider
     {
-        public Task EmitEventAsync(TelemetryEvent telemetryEvent)
+        public void EmitEvent(TelemetryEvent telemetryEvent)
         {
             TelemetryActivity.EmitTelemetryEvent(telemetryEvent);
-            return Task.CompletedTask;
         }
 
         public async Task PostFaultAsync(Exception e, string callerClassName, [CallerMemberName] string callerMemberName = null, IDictionary<string, object> extraProperties = null)

diff --git a/...NuGet.Clients/NuGet.VisualStudio.Implementation/Extensibility/VsFrameworkCompatibility.cs b/...NuGet.Clients/NuGet.VisualStudio.Implementation/Extensibility/VsFrameworkCompatibility.cs
@@ -33,7 +33,8 @@ public IEnumerable<FrameworkName> GetNetStandardFrameworks()
                 return DefaultFrameworkNameProvider
                     .Instance
                     .GetNetStandardVersions()
-                    .Select(framework => new FrameworkName(framework.DotNetFrameworkName));
+                    .Select(framework => new FrameworkName(framework.DotNetFrameworkName))
+                    .ToList();
             }
             catch (Exception exception)
             {
@@ -65,7 +66,8 @@ public IEnumerable<FrameworkName> GetFrameworksSupportingNetStandard(FrameworkNa
                 return CompatibilityListProvider
                     .Default
                     .GetFrameworksSupporting(nuGetFramework)
-                    .Select(framework => new FrameworkName(framework.DotNetFrameworkName));
+                    .Select(framework => new FrameworkName(framework.DotNetFrameworkName))
+                    .ToList();
             }
             catch (Exception exception)
             {