Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] account_reconcile_oca: Fix currency and amount when using reconciliation models #792

Conversation

sergiobstoj
Copy link
Member

@sergiobstoj sergiobstoj commented Jan 31, 2025

When using manual reconcile model to reconcile, the amount in currency is not properly updated.

Steps to reproduce in runbot:

  1. Create Journal with foreign currency (for example EUR) and bank type.
  2. Create Reconciliation Model as writeoff_button type with some account in counterpart entries.
  3. Go to Dashboard -> Get into journal created in step 1 -> Create.
  4. Set any amount and any label and Save it.
  5. Click on your statement and click on reconciliation model button.
  6. Amount in currency has the wrong currency and wrong amount.
wrong-currency-rec-model.mp4

Behaviour with PR:

Reproducing the same steps, currency and amount are now correctly displayed.

correct-currency-rec-model.mp4

@OCA-git-bot
Copy link
Contributor

Hi @etobella,
some modules you are maintaining are being modified, check this out!

@sergiobstoj sergiobstoj force-pushed the 16.0-fix-account_reconcile_oca-_reconcile_data_by_model branch from f1249d7 to 092341b Compare January 31, 2025 12:32
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review OK

@pedrobaeza pedrobaeza added this to the 16.0 milestone Feb 3, 2025
@pedrobaeza
Copy link
Member

Is this still in draft?

@sergiobstoj sergiobstoj marked this pull request as ready for review February 3, 2025 17:07
@sergiobstoj
Copy link
Member Author

it's ready!

@pedrobaeza
Copy link
Member

/ocabot merge patch

Please fw-port it to upper versions.

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-792-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit cdad4e0 into OCA:16.0 Feb 3, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at cec1221. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants