We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distribution StdDiff calculation should follow a published standard.
The current DistributionItem std diff calculation is slightly different than what is in literature.
See this line of code, and note the proper calculation should use the avg of the sum of squares.
current:
double sd = Math.sqrt(sd1 * sd1 + sd2 * sd2);
proposed:
double sd = Math.sqrt((sd1 * sd1 + sd2 * sd2) / 2.0 );
The text was updated successfully, but these errors were encountered:
Fix std diff calculation for distribution item.
4f073e4
Fixes #1904.
a9bc1da
ac658b8
Fixes OHDSI#1904.
Successfully merging a pull request may close this issue.
Expected behavior
Distribution StdDiff calculation should follow a published standard.
Actual behavior
The current DistributionItem std diff calculation is slightly different than what is in literature.
Steps to reproduce behavior
See this line of code, and note the proper calculation should use the avg of the sum of squares.
current:
proposed:
The text was updated successfully, but these errors were encountered: