Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect StdDiff calculation for continuous values #1904

Closed
chrisknoll opened this issue Jul 6, 2021 · 0 comments · Fixed by #1905
Closed

Incorrect StdDiff calculation for continuous values #1904

chrisknoll opened this issue Jul 6, 2021 · 0 comments · Fixed by #1905
Milestone

Comments

@chrisknoll
Copy link
Collaborator

chrisknoll commented Jul 6, 2021

Expected behavior

Distribution StdDiff calculation should follow a published standard.

Actual behavior

The current DistributionItem std diff calculation is slightly different than what is in literature.

Steps to reproduce behavior

See this line of code, and note the proper calculation should use the avg of the sum of squares.

current:

double sd = Math.sqrt(sd1 * sd1 + sd2 * sd2);

proposed:

double sd = Math.sqrt((sd1 * sd1 + sd2 * sd2) / 2.0 );
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants