Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Achilles DDL not working on Databricks Spark #2256

Closed
TomWhite-MedStar opened this issue Apr 20, 2023 · 1 comment
Closed

Achilles DDL not working on Databricks Spark #2256

TomWhite-MedStar opened this issue Apr 20, 2023 · 1 comment

Comments

@TomWhite-MedStar
Copy link
Contributor

Expected behavior

The DDL generated by the Achilles DDL WebAPI for spark should run properly.

Actual behavior

The generated DDL includes two WITH clauses within the same SQL statement, which throws an error.

Steps to reproduce behavior

  1. Generate DDL for spark from Achilles DDL WebAPI. - attached:
    achilles_ddl-spark.sql.txt
  2. The error is on line 99, which reads WITH insertion_temp AS (
  3. If that line is changed to , insertion_temp AS (, the query runs properly.
@chrisknoll chrisknoll moved this to Review Complete in Atlas/WebAPI Issue Triage Apr 21, 2023
TomWhite-MedStar added a commit to TomWhite-MedStar/WebAPI that referenced this issue May 9, 2023
@TomWhite-MedStar
Fix issue OHDSI#2256
5659515
@TomWhite-MedStar TomWhite-MedStar mentioned this issue May 9, 2023
Merged
chrisknoll pushed a commit that referenced this issue May 17, 2023
@TomWhite-MedStar
Fix issue #2256 (#2269)
f50bffb 
Refactored query so that parsed correctly by SqlRender for Spark
@anthonysena anthonysena moved this to ✅ Done in Atlas/WebAPI v2.14 Jul 18, 2023
pieterlukasse pushed a commit to pieterlukasse/WebAPI that referenced this issue Sep 6, 2023
@TomWhite-MedStar @pieterlukasse
Fix issue OHDSI#2256 (OHDSI#2269)
5a34841 
Refactored query so that parsed correctly by SqlRender for Spark
@konstjar
Copy link
Contributor

konstjar commented Oct 5, 2023

Closing since the issue was addressed in #2269 and merged.

@konstjar konstjar closed this as completed Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Atlas/WebAPI Issue Triage
Status: Review Complete
Atlas/WebAPI v2.14
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@konstjar @TomWhite-MedStar