Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security fixes: add embed tomcat dependency 8.5.78 #2041

Closed
wants to merge 1 commit into from

Conversation

anton-abushkevich
Copy link
Contributor

No description provided.

Copy link
Contributor

@alex-odysseus alex-odysseus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a pull request to 'master' first and then a cherry-pick to 'master-2.11'

Any reason not to use the latest 8.5.81? Please additionally extract a new property and place it on top as we do for the others

Please place two last dependencies right under

spring-boot-starter-jdbc

as in the experimental branch

Additionally I would add a few comments to the pom.xml that we are intentionally overriding the Tomcat version from Spring Boot 1.5.22.RELEASE and assuming tomcat-jdbc.jar will be in the Tomcat installation folder (\apache-tomcat-8.5.xxx\lib)

Furthermore it is important to mention that the WebAPI.war.original file should not contain overridden libraries

Additionally please place

@anton-abushkevich
Copy link
Contributor Author

I will close this PR and create another one form master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants