-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hard coded colors #2414
Comments
You should modify the tailwind configuration. Since we moved to tailwindcss |
Is it possible to ask for an example? For example, how to change the top bar color - the one with the tool icons? |
@sedghi that was a great decision. @nicoesiea i haven't tried, but from my experience with tailwind: Change this file |
Just be careful, there are two tailwind.config.js files (the first in the APP folder and the second in UI). |
Bug Report
Theme colors can't overwrite hard coded colors in certain places.
Example here:
https://github.com/OHIF/Viewers/blob/master/platform/ui/src/components/studyBrowser/StudyBrowser.styl#L6
Describe the Bug
When trying to overwrite the default colors some components wont take the color from the :root css variables.
How to find all hardcoded colors:
search for
#([a-f]|[A-F]|[0-9]){3}(([a-f]|[A-F]|[0-9]){3})?
and exclude:
*.svg, *.lock, *.md
Solution suggestion:
Replace them with css variables.
e.g. change
background-color: black
tobackground-color: var(--primary-background-color)
The text was updated successfully, but these errors were encountered: