Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theming splitButton #3767

Open
nicoesiea opened this issue Nov 6, 2023 · 2 comments
Open

Theming splitButton #3767

nicoesiea opened this issue Nov 6, 2023 · 2 comments

Comments

@nicoesiea
Copy link

Describe the Bug

There are two places where "text-[#348cfd]" are hard-coded in the file SplitButton.tsx

image

Is it normal? This code completely break the tailwind theming style

Steps to Reproduce

  1. Open the file ...\platform\ui\src\components\SplitButton\SplitButton.tsx
  2. Go to the line 69, or 170
  3. Observe the hard coded value: text-[#348CFD]

The current behavior

Whatever I change the colors in the configuration file, the color is always the same on the split-button

The expected behavior

The color should be use from the tailwind color variable, not an hard-coded value

OS

Windows 10

Node version

16.18.1

Browser

Chrome

@nicoesiea nicoesiea added the Awaiting Reproduction Can we reproduce the reported bug? label Nov 6, 2023
@nicoesiea
Copy link
Author

Another one is #348CFD in the navigation-panel-right-hide.svg
And here, it is even more complex because it is in the SVG resource

@sedghi
Copy link
Member

sedghi commented May 4, 2024

we are re-vamping our UI from ground up with shadcn, stay tuned

@sedghi sedghi removed the Awaiting Reproduction Can we reproduce the reported bug? label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants