Refactor Fieldset component test file to new format #3435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adi-unni
added
the
Tech improvements
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rmccar
changed the title
rmccar
changed the title
rmccar
requested changes
Nov 22, 2024
rmccar
reviewed
Dec 6, 2024
rmccar
reviewed
Mar 7, 2025
Comment on lines
9
to
18
| describe('GIVEN: Params: accessibility', () => { | ||
| describe('WHEN: all necessary params are provided', () => { | ||
| const $ = cheerio.load(renderComponent('fieldset', EXAMPLE_FIELDSET)); | ||
|
|
||
| test('THEN: jest-axe checks pass', async () => { | ||
| const results = await axe($.html()); | ||
| expect(results).toHaveNoViolations(); | ||
| }); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
I would just move this THEN into the "WHEN: legend is provided" test and remove all this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Fixes: #156
Refactors the fieldset component test file to the new agreed format.
How to review this PR
Run tests locally and check that the messages make sense and describe what is being tested
Ask yourself....
yarn test --testNamePattern="FOR: Macro: Fieldset"