Increase ONS logo size #3505
Open
Increase ONS logo size #3505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rmccar
reviewed
Feb 21, 2025
...st__foundations_page-template_example-base-page-template-block-areas_0_document_2_mobile.png
Outdated
Show resolved
Hide resolved
admilne
approved these changes
Mar 5, 2025
rmccar
reviewed
Mar 6, 2025
rmccar
reviewed
Mar 6, 2025
rmccar
reviewed
Mar 6, 2025
Comment on lines
+66
to
+76
| &__logo-large { | ||
| @include mq('2xs', 414px) { | ||
| display: none; | ||
| } | ||
| } | ||
|
|
||
| &__logo-small { | ||
| @include mq(415px) { | ||
| display: none; | ||
| } | ||
| } |
There was a problem hiding this comment.
Both these are setting the same thing, cant they be combined? Then the include can be removed too
Co-authored-by: rmccar <[email protected]>
Co-authored-by: rmccar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
This ticket was created as a subset of ONSDESYS-162 to adjust the ONS logo size, ensuring it has a height of 24px to match the figma design
As part of this update, the footer component has been modified so that the ONS logo switches to the stacked version based on screen size.
How to review this PR
This needs to be completed by the person raising the PR.