Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Line chart variant of the Chart component #3506

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

precious-onyenaucheya-ons
Copy link
Contributor

@precious-onyenaucheya-ons precious-onyenaucheya-ons commented Feb 24, 2025

What is the context of this PR?

Addressed ONSDESYS-297

This PR introduces the Line Chart variant of the Chart component, built based on the Torchbox POC and technical specifications. An example implementation of the chart is also included.

How to review this PR

  1. Verify that the Line Chart component is implemented correctly and adheres to the Torchbox POC and technical specifications.
  2. Check that the component is fully responsive across different screen sizes.
  3. Confirm that the component has passed all required testing (backstop JS tests, snapshot tests, visual regression tests, and manual testing in the Python environment).
  4. Validate that the component meets accessibility criteria.

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

Copy link

netlify bot commented Feb 24, 2025

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit 6b74f6d
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/67cef6e16a47c10008259daa
😎 Deploy Preview https://deploy-preview-3506--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@precious-onyenaucheya-ons precious-onyenaucheya-ons changed the title Feature/set up highchart Set up highchart Feb 24, 2025
@precious-onyenaucheya-ons precious-onyenaucheya-ons added the Enhancement Change of existing feature label Feb 24, 2025
Copy link
Collaborator

@helenb helenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @precious-onyenaucheya-ons thank you for this - let's have a look through in our call this afternoon. I am also going to do some work to refine the line chart ticket tomorrow so we can get a better idea of what work is still to be done.

@precious-onyenaucheya-ons precious-onyenaucheya-ons marked this pull request as ready for review March 7, 2025 11:59
@precious-onyenaucheya-ons precious-onyenaucheya-ons requested a review from a team as a code owner March 7, 2025 11:59
@precious-onyenaucheya-ons precious-onyenaucheya-ons changed the title Set up highchart Added Line chart variant of the Chart component Mar 7, 2025
@helenb helenb mentioned this pull request Mar 10, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Change of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants