Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variables.GetByID return null variable when api error. #784

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Variables.GetByID return null variable when api error. #784

merged 2 commits into from
Sep 17, 2024

Conversation

HuyPhanNguyen
Copy link
Collaborator

Variables.GetByID return null variable when api error which cause provider to panic when try to set variable.SpaceId

Fixes 783

IsaacCalligeros95
IsaacCalligeros95 approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@IsaacCalligeros95 IsaacCalligeros95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HuyPhanNguyen HuyPhanNguyen merged commit be44617 into main Sep 17, 2024
22 checks passed
@HuyPhanNguyen HuyPhanNguyen deleted the bugfix/sc-93030-null-pointer-when-get-variable-api-error branch September 17, 2024 02:44
This was referenced Oct 17, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsaacCalligeros95 IsaacCalligeros95 IsaacCalligeros95 approved these changes

@hnrkndrssn hnrkndrssn Awaiting requested review from hnrkndrssn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HuyPhanNguyen @IsaacCalligeros95