fix: log when tenant not associated to common variable template

[mjhilton]

Add better detection and a better error message when trying to provide a value for a Common Variable Template, but the Tenant has not yet been connected to a Project that includes the Library Set that defines the template.

fixes #790

How to review

• Detection logic feels pretty unstreamlined and verbose; happy for suggestions on more canonical golang or a better approach.
• I don't understand why the compiler warning requries error messages to start with a lower-case, that feels a bit uncivilized to me. Am I doing the error message approach wrong?

[domenicsim1]

Overall logic looks good.
Put some comments down on some Go things.

[domenicsim1]

Detection logic feels pretty unstreamlined and verbose; happy for suggestions on more canonical golang or a better approach.

I would like to know more about what you mean here.

I don't understand why the compiler warning requries error messages to start with a lower-case, that feels a bit uncivilized to me. Am I doing the error message approach wrong?

My suggestion here would be to return a diag.diagnostic that we append to resp . You can do so with diag.NewErrorDiagnostic(summary, detail) Errors are designed for Go, and target "developer" consummation when they are called with panic(err) or being logged. In this case having them lower-case fits with how panic and log formats the errors in Go. They are not designed for user facing errors but terraform diag is.

[mjhilton]

I would like to know more about what you mean here.

Flipping the logical "polarity" of the checks between the three conditions feels a little off. By that, I mean that in the first one - checking if the Tenant is connected to any Projects - I'm returning an error condition; then, I'm looking for a positive condition in the loop that searches for the template and returning nil if it's good; then I'm going back to returning an error condition again. To illustrate with some pseudocode, I would usually expect this style of return-early method to follow a pattern like this:

if (a thing) 
  return true;

if (another thing) 
  return true;

return false

but instead I'm doing

if (a thing)
  return false

if (another thing)
  return true

return false

So it's fine, it just doesn't feel nice. Happy for any suggestion on how to improve this; I couldn't think of anything.

[mjhilton]

Also, what are these iffy-loops and where is LINQ? 🤪