Skip to content
This repository was archived by the owner on Oct 2, 2024. It is now read-only.

ChunkedUploadProvider with files >2GB and ItemByPath fixes. #232

Closed
wants to merge 3 commits into from

Conversation

armandpostma
Copy link

A bug was fixed in the ChunkedUploadProvider which caused it to miscalculate the chunksizes when the file was larger than Int32.Max bytes.

Both the ItemRequestBuilder.ItemWithPath and the OneDriveClient.ItemWithPath methods incorrectly encoded the Uri when a hashtag character was in the path, resulting in an "API not found" error.

A Unit Test was added for the ItemWithPath situation and additional Unit Tests were added to validate the OneDriveClient.ItemWithPath method is working as expected.

… calculated incorrectly resulting in negative sizes when exceeding a value of Int32.Max, preventing files larger than 2GB to be uploaded.
….ItemWithPath methods caused by an incorrectly encoded Uri resulting in "API not found" errors whenever the path contains a hashtag/number-symbol # character.
… hashtag/number-symbol # (ItemRequestTests.ItemByPath_BuildRequestWithHashtag, ItemRequestTests.OneDriveClient_ItemByPath_BuildRequestWithHashtag), and also, added some additional Unit Tests to validate that the OneDriveClient.ItemByPath is working as expected.
@baywet
Copy link
Member

baywet commented Oct 2, 2024

Thank you for reaching out and for your patience. This SDK is being officially deprecated. See #259 for more information

@baywet baywet closed this Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants