This repository was archived by the owner on Oct 2, 2024. It is now read-only.
ChunkedUploadProvider with files >2GB and ItemByPath fixes. #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… calculated incorrectly resulting in negative sizes when exceeding a value of Int32.Max, preventing files larger than 2GB to be uploaded.
….ItemWithPath methods caused by an incorrectly encoded Uri resulting in "API not found" errors whenever the path contains a hashtag/number-symbol # character.
… hashtag/number-symbol # (ItemRequestTests.ItemByPath_BuildRequestWithHashtag, ItemRequestTests.OneDriveClient_ItemByPath_BuildRequestWithHashtag), and also, added some additional Unit Tests to validate that the OneDriveClient.ItemByPath is working as expected.
|
Thank you for reaching out and for your patience. This SDK is being officially deprecated. See #259 for more information |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was fixed in the ChunkedUploadProvider which caused it to miscalculate the chunksizes when the file was larger than Int32.Max bytes.
Both the ItemRequestBuilder.ItemWithPath and the OneDriveClient.ItemWithPath methods incorrectly encoded the Uri when a hashtag character was in the path, resulting in an "API not found" error.
A Unit Test was added for the ItemWithPath situation and additional Unit Tests were added to validate the OneDriveClient.ItemWithPath method is working as expected.