Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][Feign] decommission 9.x support #6445

Merged
merged 2 commits into from
May 28, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion bin/java-petstore-all.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
# update java petstore clients for all supported http libraries

./bin/java-petstore-feign-10x.sh
./bin/java-petstore-feign.sh
./bin/java-petstore-google-api-client.sh
./bin/java-petstore-jersey1.sh
./bin/java-petstore-jersey2-java8.sh
Expand Down
5 changes: 0 additions & 5 deletions bin/java-petstore-feign-9x.json

This file was deleted.

5 changes: 0 additions & 5 deletions bin/java-petstore-feign.json

This file was deleted.

40 changes: 0 additions & 40 deletions bin/java-petstore-feign.sh

This file was deleted.

1 change: 0 additions & 1 deletion bin/windows/java-petstore-all.bat
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
call .\bin\windows\java-petstore-feign-10x.bat
call .\bin\windows\java-petstore-feign.bat
call .\bin\windows\java-petstore-google-api-client.bat
call .\bin\windows\java-petstore-jersey1.bat
call .\bin\windows\java-petstore-jersey2-java8.bat
Expand Down
10 changes: 0 additions & 10 deletions bin/windows/java-petstore-feign.bat

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -237,21 +237,9 @@ public void processOpts() {
}
additionalProperties.put(PLAY_VERSION, playVersion);

// OpenFeign
// default to feign 10.x
if (additionalProperties.containsKey(FEIGN_VERSION)) {
this.setFeignVersion(additionalProperties.get(FEIGN_VERSION).toString());

if ("10.x".equals(feignVersion)) {
additionalProperties.put("useFeign10", true);
} else if ("9.x".equals(feignVersion)) {
additionalProperties.put("useFeign10", false);
once(LOGGER).warn("Feign 9.x support has been deprecated. Please use 10.x (default) instead.");
} else {
throw new RuntimeException("Ivalid feignOoption '{}'. Must be '10.x' or '9.x' (deprecated).");
}
} else {
// default to feign 10.x
additionalProperties.put("useFeign10", true);
once(LOGGER).warn("feignVersion has been deprecated. 10.x is the default.");
}
additionalProperties.put(FEIGN_VERSION, feignVersion);

Expand Down
4 changes: 1 addition & 3 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -772,7 +772,7 @@
</property>
</activation>
<modules>
<module>samples/client/petstore/java/feign</module>
<module>samples/client/petstore/java/feign10x</module>
</modules>
</profile>
<profile>
Expand Down Expand Up @@ -1260,7 +1260,6 @@
<module>samples/client/petstore/scala-httpclient</module>
<module>samples/client/petstore/scalaz</module>
<module>samples/client/petstore/clojure</module>
<module>samples/client/petstore/java/feign</module>
<module>samples/client/petstore/java/feign10x</module>
<module>samples/client/petstore/java/jersey1</module>
<module>samples/client/petstore/java/jersey2-java8</module>
Expand Down Expand Up @@ -1354,7 +1353,6 @@
<module>samples/client/petstore/dart-jaguar/flutter_petstore/openapi</module>
<module>samples/client/petstore/scala-akka</module>
<module>samples/client/petstore/scala-httpclient</module>
<module>samples/client/petstore/java/feign</module>
<module>samples/client/petstore/java/jersey1</module>
<module>samples/client/petstore/java/okhttp-gson</module>
<module>samples/client/petstore/java/retrofit</module>
Expand Down
21 changes: 0 additions & 21 deletions samples/client/petstore/java/feign/.gitignore

This file was deleted.

23 changes: 0 additions & 23 deletions samples/client/petstore/java/feign/.openapi-generator-ignore

This file was deleted.

81 changes: 0 additions & 81 deletions samples/client/petstore/java/feign/.openapi-generator/FILES

This file was deleted.

This file was deleted.

22 changes: 0 additions & 22 deletions samples/client/petstore/java/feign/.travis.yml

This file was deleted.

43 changes: 0 additions & 43 deletions samples/client/petstore/java/feign/README.md

This file was deleted.

Loading