Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using coresmd instead of dnsmasq in podman-quadlets recipe #84

Merged
merged 14 commits into from
Dec 2, 2024

Conversation

travisbcotton
Copy link
Contributor

Adding coresmd to provide dhcp. Also removing dnsmasq data.

coredhcp does not include a tftp server right now, still need to figure out if that is coming from coresmd or an external service.

@rainest rainest mentioned this pull request Nov 7, 2024
3 tasks
@travisbcotton travisbcotton force-pushed the trcotton/quadlet-coresmd branch from 2a0247d to 5a2335e Compare November 25, 2024 16:00
@travisbcotton travisbcotton marked this pull request as ready for review November 26, 2024 15:58
Copy link
Contributor

@synackd synackd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished with my initial review. I don't think it's too big of a jump to use the newest (v0.2.0) coresmd as it only requires one small config change, and we can get rid of the iPXE bootloader package/files.

Let me know what you think.

Copy link
Contributor

@synackd synackd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unable to test, but this looks good to me.

@travisbcotton travisbcotton merged commit 5618c94 into main Dec 2, 2024
@synackd synackd deleted the trcotton/quadlet-coresmd branch December 3, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants