-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to using coresmd instead of dnsmasq in podman-quadlets recipe #84
Conversation
Changing author and signing
changing author and signing commit
2a0247d
to
5a2335e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished with my initial review. I don't think it's too big of a jump to use the newest (v0.2.0) coresmd as it only requires one small config change, and we can get rid of the iPXE bootloader package/files.
Let me know what you think.
lanl/podman-quadlets/roles/configs/templates/coredhcp/coredhcp.yaml.j2
Outdated
Show resolved
Hide resolved
…ry based on the detected architecture
… default in inventory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am unable to test, but this looks good to me.
Adding coresmd to provide dhcp. Also removing dnsmasq data.
coredhcp does not include a tftp server right now, still need to figure out if that is coming from coresmd or an external service.