Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RST Noise Control] : No default value provided for variable: "RST_NOISE_CONTROL_BASEURL" #3254

Closed
romain-filigran opened this issue Jan 10, 2025 · 2 comments · Fixed by #3443
Closed

[RST Noise Control] : No default value provided for variable: "RST_NOISE_CONTROL_BASEURL" #3254

romain-filigran opened this issue Jan 10, 2025 · 2 comments · Fixed by #3443
Assignees
@helene-nguyen
Labels
bug use for describing something not working as expected partner support use to identify an issue related to feature developed & maintained by the third-party vendor. solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone
Release 6.5.6

Comments

@romain-filigran
Copy link
Member

Description

In the documentation, the “RST_NOISE_CONTROL_BASEURL” variable is documented as “Not required” but no default value is provided in the code.
Update the code to provide a default value or update the documentation.
@romain-filigran romain-filigran added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team and removed needs triage use to identify issue needing triage from Filigran Product team labels Jan 10, 2025
@romain-filigran
Copy link
Member Author

romain-filigran commented Jan 10, 2025 •
edited
Loading

Hello @k1r10n: Could you have a look into this issue ? Thanks in advance

@romain-filigran romain-filigran added the partner support use to identify an issue related to feature developed & maintained by the third-party vendor. label Jan 10, 2025
@romain-filigran romain-filigran added this to the Bugs backlog milestone Jan 10, 2025
@k1r10n
Copy link
Contributor

k1r10n commented Jan 16, 2025

Thanks! Noted. The value is specified in the default configs, so no complains from users, but yes, good to fix it.

@k1r10n k1r10n mentioned this issue Feb 18, 2025
Merged
4 tasks
helene-nguyen pushed a commit that referenced this issue Mar 10, 2025
@k1r10n
[RST CLOUD] Connector Updates. New RST WHOIS API Connector (#3254)(#3598
2c5f513 
)
@helene-nguyen helene-nguyen self-assigned this Mar 10, 2025
@helene-nguyen helene-nguyen linked a pull request Mar 10, 2025 that will close this issue
[RST CLOUD] Connector Updates. New RST WHOIS API Connector #3443
Merged
4 tasks
@helene-nguyen helene-nguyen added the solved use to identify issue that has been solved (must be linked to the solving PR) label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@helene-nguyen helene-nguyen

Labels
bug use for describing something not working as expected partner support use to identify an issue related to feature developed & maintained by the third-party vendor. solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Milestone
Release 6.5.6
Development

Successfully merging a pull request may close this issue.

[RST CLOUD] Connector Updates. New RST WHOIS API Connector k1r10n/opencti-connectors
3 participants
@k1r10n @helene-nguyen @romain-filigran