-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[InfoBlox Threat Defense] Create the Connector #3313
Conversation
Create the stream connector to integrate OpenCTI with InfoBlox Threat Defense.
9818df2
to
0f4b30d
Compare
b513b96
to
11a05bf
Compare
@The-Stuke : Thank you for your contribution. In order to review and merge your contribution, can you resolve the formatting issues detected? You can solve it by running the following command on your code: “isort --profile black”. |
Hi @romain-filigran I ran isort . --profile black in the directory of the new connector and now the error is "/home/circleci/repo/external-import/crowdstrike/src/crowdstrike_feeds_connector/indicator/builder.py Imports are incorrectly sorted and/or formatted." Do you want me to update that file as well as it is out of the connector I am made? |
@The-Stuke Thank you for you contribution! Also,, please ensure that your commits are verified and sign it with GPG :) |
Hi @helene-nguyen, not sure why the test keeps failing. I was able to update both black and isort to the latest version, which did reformat my code, so I have pushed that now, but still fails the circleci check on the main.py file. Locally it tells me no files would be changing. |
@The-Stuke You should be on the connector root folder, as I can see on the screenshot, you are in your connector folder. Could you do it again? |
There are some root rules reason, sorry if it's confusing.
And then it should be good |
@The-Stuke in your last screenshot, you run the command in |
When I run both commands at in the root directory I get the reformat of a bunch of files and a lot of errors thrown. Looking through it I do not see my infoblox connector even being referenced. I assume there is probably something wrong on my end, but I am not sure where to troubleshoot this.
|
@The-Stuke ok I see, I don't know why you have this output, maybe a local config interferes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linter and format have been made by @flavienSindou (thank you) from our team :) sorry if it was painful by your side
Everything looks good to me, we have added minor changes to do to realign with our best practices.
Could you make the changes and it should be good to be merged :) Thank you again for you contribution
Co-authored-by: Helene Nguyen <[email protected]>
Co-authored-by: Helene Nguyen <[email protected]>
Co-authored-by: Helene Nguyen <[email protected]>
Co-authored-by: Helene Nguyen <[email protected]>
Co-authored-by: Helene Nguyen <[email protected]>
Co-authored-by: Helene Nguyen <[email protected]>
Co-authored-by: Helene Nguyen <[email protected]>
Co-authored-by: Helene Nguyen <[email protected]>
Co-authored-by: Helene Nguyen <[email protected]>
Co-authored-by: Helene Nguyen <[email protected]>
Hello @The-Stuke , could you please sign these commits Here is a detailed procedure : https://medium.com/@aamir.shehzad3346875/how-to-sign-previous-commit-that-have-already-been-pushed-4683a7060e19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good for me :)
Proposed changes
Related issues
Checklist
Further comments