[Sentinel-Intel] Improve error handling in Sentinel API client #3445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- raise errors instead of returning None in _send_request() - refacto error handling in API handler - handle API handler errors in process_message()
Powlinett
added
filigran team
helene-nguyen
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Thank you @Powlinett for this improvement, really appreciate your effort in making this better! 🚀
Everything looks good to me :)
|
Can we merge this one @helene-nguyen @Powlinett? |
Powlinett
removed
the
do not merge
flavienSindou
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist
Further comments
Related to #3425