[Comlaude] connector improvements #3459
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'm coming to you to send the commit about the comlaude connector, you will see the details below :
Removal of obsolete elements:
The _get_interval method and its associated variable have been removed, as they were no longer used in new versions (obsolete). Scheduling is now handled via schedule_iso.
Deprecated configuration removed:
The update_existing_data variable has been removed, as has its use in the send_stix2_bundle call.
Improved quality of STIX bundles:
When sending bundles, the cleanup_inconsistent_bundle=True parameter is now used, and all necessary markings (such as TLP_AMBER) are included.
Logging modernization:
Old calls to self.helper.log_error() have been replaced by self.helper.connector_logger.error() with a structured format (message + variable dictionary).
Work ID correctly closed:
In the finally block, the Work ID is always marked as completed via self.helper.api.work.to_processed, even in the event of an error.
Date and exception handling methods updated:
The use of datetime.utcnow() (deprecated in Python 3.12) has been replaced.
A traceback is now displayed in the main block for better error handling.
Proposed changes
Related issues
*#3055
*
Checklist
Further comments