Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sentinelone-indicator-stream] A Stream Connector allowing Indicators to be pushed to a SentinelOne Account as IOCs #3509

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

maximus-debski
Copy link

@maximus-debski maximus-debski commented Feb 27, 2025

Proposed changes

  • Initial Creation of the SentinelOne Indicator Stream Connector

Related issues

  • NA

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

NOTE: This connector's development occurred in the 'sentinelone-indicators' pull request. This is a fresh, new pull request that contains signed commits only. See #3269

@romain-filigran romain-filigran added this to the PRs backlog milestone Feb 27, 2025
@helene-nguyen helene-nguyen added the community use to identify PR from community label Feb 28, 2025
Copy link
Member

@Powlinett Powlinett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again four your contribution @maximus-debski 🙏
Except a small typo that prevent docker to launch the container the connector seems to work fine 🙌
Would you mind to remove "-stream" from the connector's name and simply call it "sentinelone-indicator" before we merge it? 😇
Thanks!

@@ -0,0 +1,23 @@
services:
sentinelone-indicator-stream-connector:
image: opencti/connector-template:6.5.1
Copy link
Member

@Powlinett Powlinett Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, please don't forget to update docker files according to the new connector's name.
Here service's name should be sentinelone-indicator and image's name should be opencti/sentinelone-indicator:6.5.1.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Powlinett, sorry for the direct ping

I just noticed this came up after applying these changes to the docker-compose:

'Failed to deploy a stack: sentinelone-indicator Pulling sentinelone-indicator Error pull access denied for opencti/sentinelone-indicator, repository does not exist or may require 'docker login': denied: requested access to the resource is denied Error response from daemon: pull access denied for opencti/sentinelone-indicator, repository does not exist or may require 'docker login': denied: requested access to the resource is denied'

After browsing Docker hub I noticed the opencti/sentinelone-indicator image wasn't listed.

Do we have some recommendations or a fix in place for this implementation? Many thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yoan-famel,
yes the connector has never been published yet, it's done automatically once merged into master. But the image's name opencti/sentinelone-indicator is correct 👍
During development you can replace the image: opencti/sentinelone-indicator:<version> by build: . for instance, but it shouldn't be committed this way, we need the image's name for automations 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community use to identify PR from community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants