-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sentinelone-indicator-stream] A Stream Connector allowing Indicators to be pushed to a SentinelOne Account as IOCs #3509
base: master
Are you sure you want to change the base?
Conversation
… to be pushed to a SentinelOne Account as IOCs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again four your contribution @maximus-debski 🙏
Except a small typo that prevent docker to launch the container the connector seems to work fine 🙌
Would you mind to remove "-stream" from the connector's name and simply call it "sentinelone-indicator" before we merge it? 😇
Thanks!
@@ -0,0 +1,23 @@ | |||
services: | |||
sentinelone-indicator-stream-connector: | |||
image: opencti/connector-template:6.5.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, please don't forget to update docker files according to the new connector's name.
Here service's name should be sentinelone-indicator
and image's name should be opencti/sentinelone-indicator:6.5.1
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Powlinett, sorry for the direct ping
I just noticed this came up after applying these changes to the docker-compose:
'Failed to deploy a stack: sentinelone-indicator Pulling sentinelone-indicator Error pull access denied for opencti/sentinelone-indicator, repository does not exist or may require 'docker login': denied: requested access to the resource is denied Error response from daemon: pull access denied for opencti/sentinelone-indicator, repository does not exist or may require 'docker login': denied: requested access to the resource is denied'
After browsing Docker hub I noticed the opencti/sentinelone-indicator image wasn't listed.
Do we have some recommendations or a fix in place for this implementation? Many thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yoan-famel,
yes the connector has never been published yet, it's done automatically once merged into master. But the image's name opencti/sentinelone-indicator
is correct 👍
During development you can replace the image: opencti/sentinelone-indicator:<version>
by build: .
for instance, but it shouldn't be committed this way, we need the image's name for automations 😇
e97d87b
to
cbdee1f
Compare
Proposed changes
Related issues
Checklist
Further comments
NOTE: This connector's development occurred in the 'sentinelone-indicators' pull request. This is a fresh, new pull request that contains signed commits only. See #3269