Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISP] Adds propagate labels from Event to Attribute option #3495 #3562

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ltheyoung
Copy link

Currently the Attributes tags take precedence over the Events tags (if attribute has tags)

This commit allows for the option to allow the labels that are present on an Event (OpenCTI Reports) to apply on top of the labels set by the Attributes (Observables and/or Indicators). While not changing behaviour by introducting a setting that defaults to the previous behaviour.

Proposed changes

  • Add setting for this new feature with default of old behaviour
  • Add the Event labels to the Attribute labels when setting is set to true, otherwise keep old behaviour

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

This would be my first PR to this project any guidance where needed is appreciated.

…latform#3495

Currently the Attributes tags take precedence over the Events tags (if attribute has tags)

This commit allows for the option to allow the labels that are present on an Event (OpenCTI Reports) to apply on top of the labels set by the Attributes (Observables and/or Indicators).
While not changing behaviour by introducting a setting that defaults to the previous behaviour.
@romain-filigran romain-filigran added the community use to identify PR from community label Mar 5, 2025
@romain-filigran romain-filigran added this to the PRs backlog milestone Mar 5, 2025
@SamuelHassine SamuelHassine force-pushed the master branch 3 times, most recently from e97d87b to cbdee1f Compare March 14, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community use to identify PR from community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants