Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Silobreaker] Fix issues and add autobackpressure #3573

Merged
merged 5 commits into from
Mar 7, 2025
Merged

[Silobreaker] Fix issues and add autobackpressure #3573

merged 5 commits into from
Mar 7, 2025

Conversation

helene-nguyen
Copy link
Member

@helene-nguyen helene-nguyen commented Mar 6, 2025 •
edited
Loading

Proposed changes

  • Handle missing data to log an error when credentials expired
  • Replace log_error with connector_logger.error (same for info) to align with the last current usage of loggers
  • Use our scheduler to have the connector auto back pressure for better handling queue ingestions
  • Complete the README

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@helene-nguyen helene-nguyen added filigran team use to identify PR from the Filigran team filigran verify Use to identify PR of connector Verified labels Mar 6, 2025
@helene-nguyen helene-nguyen self-assigned this Mar 6, 2025
@helene-nguyen helene-nguyen linked an issue Mar 6, 2025 that may be closed by this pull request
[Silobreaker] Issue on first run of connector #3501
Closed
Megafredo
Megafredo approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@Megafredo Megafredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's ok with me, despite my suggestion ;)

external-import/silobreaker/src/silobreaker.py
if data and data.get("Description"):
self._import_documents(data["Description"], work_id, delta_days)
else:
self.helper.connector_logger.error(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be interesting to add the current list to the logs !

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I will add it, thanks !

@helene-nguyen helene-nguyen merged commit ba16494 into master Mar 7, 2025
4 checks passed
@helene-nguyen helene-nguyen deleted the issue/3501-silo-verify branch March 7, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Megafredo Megafredo Megafredo approved these changes

@pdamoune pdamoune Awaiting requested review from pdamoune

@Powlinett Powlinett Awaiting requested review from Powlinett

@flavienSindou flavienSindou Awaiting requested review from flavienSindou

Assignees

@helene-nguyen helene-nguyen

Labels
filigran team use to identify PR from the Filigran team filigran verify Use to identify PR of connector Verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Silobreaker] Issue on first run of connector
2 participants
@helene-nguyen @Megafredo