Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better save for jobs panel #568

Closed
taylordowns2000 opened this issue Jan 9, 2023 · 1 comment · Fixed by #777
Closed

Better save for jobs panel #568

taylordowns2000 opened this issue Jan 9, 2023 · 1 comment · Fixed by #777
Assignees

Comments

@taylordowns2000
Copy link
Member

taylordowns2000 commented Jan 9, 2023

  1. When creating a new job, the "Save" button should say "Create" rather than save because the record is not stored until the button is pressed. This will help with a current UX frustration where users cannot tell if they are creating a new job or editing an existing one.
  2. As anyone, I'd like to be able to save my changes to a job without closing the jobs panel. (Having the panel close is particularly frustrating when I'm first building a job, as certain features are blocked until the job is saved.)
  3. As a developer-user, I'd like command-s or control-s to save my job expression and not close the panel.
  4. The "cancel" button should instead say "close" and if I attempt to close or click away with unsaved changes I should get a warning indicating that i have unsaved changes.
@taylordowns2000 taylordowns2000 added this to the RC1 milestone Apr 3, 2023
@taylordowns2000 taylordowns2000 changed the title Better save (with key binding) for jobs panel Better save for jobs panel Apr 3, 2023
@mtuchi mtuchi self-assigned this Apr 5, 2023
@mtuchi mtuchi linked a pull request Apr 5, 2023 that will close this issue
4 tasks
@taylordowns2000
Copy link
Member Author

taylordowns2000 commented Apr 6, 2023

@amberrignell , @mtuchi , i'm moving the "warn on unsaved changes" bit here (see x-ed out item 4 above) into a new issue: #780

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants