Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filtered search params to history URL #660

Closed
2 tasks
amberrignell opened this issue Feb 22, 2023 · 1 comment · Fixed by #744
Closed
2 tasks

Add filtered search params to history URL #660

amberrignell opened this issue Feb 22, 2023 · 1 comment · Fixed by #744
Assignees

Comments

@amberrignell
Copy link
Contributor

amberrignell commented Feb 22, 2023

User story

As a user that has carried out a filtered search on the history page, I would like my search parameters to be added to the history page url, so that I can easily share it with a colleague or someone from support.

Details

Currently, if I carry out a filtered search on the history page, the URL does not get updated. This means that
(a) I can't share the filtered view with anyone
(b) if I click on a run, then go 'back' I lose my search
(c) if I reload the page, I lose my search

Implementation notes

@taylordowns2000 doesn't think this should be too tricky... can we set and read the params like this: https://elixirforum.com/t/handling-and-retrieving-query-parameters-in-live-view/49006 ?

@stuartc any input/considerations here?

Release notes

  • Add parameters to filtered history page URL

User acceptance criteria

  • When I make a filtered search, the history page url is updated
  • If I close the tab and paste the URL, I am taken to the same view (I see the same filtered list of work orders) and the search bar inputs are the same (ex: if I have unselected "Failed' status, when I go to the URL it is still unselected)
@amberrignell
Copy link
Contributor Author

Removing requirement for expanded work order getting added to the url params. Created a separate issue for this to be addressed at a later date. https://app.zenhub.com/workspaces/product-engineering-6305f22ada44914905485ab1/issues/gh/openfn/lightning/775

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants