Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show that a node is invalid #956

Closed
stuartc opened this issue Jul 25, 2023 · 2 comments · Fixed by #1077
Closed

Show that a node is invalid #956

stuartc opened this issue Jul 25, 2023 · 2 comments · Fixed by #1077
Assignees

Comments

@stuartc
Copy link
Member

stuartc commented Jul 25, 2023

Provide some UX/UI feedback on the diagram that a job/trigger is in an invalid state.

We need some designs and input on what this should look like.

Technical Notes

This is likely entirely in the WorkflowEditor/Diagram space, the workflow params/store objects contain an error key that when is an array (and longer than 0) signifies there are validation errors on the changeset.

@stuartc stuartc added needs detail More detail is needed before development can start js/ts/tailwind-css labels Jul 25, 2023
@osinga
Copy link
Collaborator

osinga commented Jul 27, 2023

Behavior

  • Only show a node's invalid state after the node settings modal has been closed for the first time to prevent giving duplicate feedback from both inside the modal form and the node.
  • Keep the node in its invalid state when subsequently opening the node settings modal, until the issues have been resolved.

Design

  • Make the node border red, and keep it red even when it's selected.
  • Make the name of jobs and triggers red.
  • Add an error label to the right of the node.
    • For horizontal conditions, show it below the node instead.

Canvas-3

@taylordowns2000 taylordowns2000 removed the needs detail More detail is needed before development can start label Aug 1, 2023
@taylordowns2000
Copy link
Member

@elias-ba , @stuartc , this was the issue! (and no, not done yet.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants