feat(syft_exc): change client and server side response handling #9012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces a significant change in how service responses are handled on both the client and server sides. **Server-side Enhancements (node/node.py)** - Responses are now wrapped before being sent. If no exceptions are raised, responses are always wrapped in `SyftSuccess`. **Client-side Enhancements (client/api.py)** - Responses to service methods are unwrapped if the `unwrap_on_success` decorator is applied (default is True). - Unwrapping involves retrieving the object returned by `SyftSuccess.unwrap_value()`, which corresponds to the original return value from the service method. **Temporary** - Introduced `UNWRAPPABLE_SERVICES_LIST`, a temporary list of services for which response unwrapping is applied. This list will be removed once all services (stashes) are migrated. By not unwrapping on success, messages are returned to the user as `SyftSuccess` (see notebooks).
This was referenced Jul 3, 2024
tcp
modified the milestones:
24Q3 - G1M3 Organic Upgradability,
24Q3 - G1M4 Organic Exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
unwrap_on_successattribute to the service method decoratorSyftSuccessunwrap_on_successattribute of the service method calledPart of #8883