Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Inconsistent use of UTC time in DateTime class #9169

Merged
merged 4 commits into from
Aug 23, 2024

Conversation

BrendanSchell
Copy link
Contributor

Description

Main change is to update the DateTime class to treat timezone consistently as UTC to avoid some inconsistencies between the use of UTC and local time.

Other minor updates:

  • replace use of utctimestamp, utcnow functions in DateTime, BaseDateTime classes
  • update sub op of DateTime / BaseDateTime to return timedelta instead of DateTime (not sure if it made sense before or was even being used)
  • fixed Asset repr when either private or mock data was empty action object (noticed incidentally trying to replicate bug)

Closes https://github.com/OpenMined/Heartbeat/issues/1475.

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Tested in notebook to make sure times / delta were correct in syncing widget.

Checklist

@BrendanSchell BrendanSchell force-pushed the bschell/fix-timestamp-syncing branch from c013691 to 258c652 Compare August 14, 2024 18:56
Copy link
Contributor

@snwagh snwagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, LGTM!

@BrendanSchell BrendanSchell force-pushed the bschell/fix-timestamp-syncing branch from 258c652 to e3f9173 Compare August 23, 2024 17:59
@IonesioJunior IonesioJunior merged commit 8ff8548 into dev Aug 23, 2024
27 checks passed
@IonesioJunior IonesioJunior deleted the bschell/fix-timestamp-syncing branch August 23, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants