Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker scale test #9240

Merged
merged 11 commits into from
Sep 3, 2024
Merged

worker scale test #9240

merged 11 commits into from
Sep 3, 2024

Conversation

shubham3121
Copy link
Member

@shubham3121 shubham3121 commented Aug 31, 2024

Description

Fixes:

  • Fix timeout issue during scaling workers in k8s

Tests:

  • Scale up operation
  • Scale down operation
  • Delete Default Worker pool deletion and recreate it.

Resolves: https://github.com/OpenMined/Heartbeat/issues/1812
Partially Resolves: https://github.com/OpenMined/Heartbeat/issues/1791

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

- fix incorrect max_count in worker_pool post worker deletion
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@shubham3121 shubham3121 changed the title [WIP] worker scale test worker scale test Sep 3, 2024
@shubham3121 shubham3121 self-assigned this Sep 3, 2024
Added admin credentials to new notebook

move scale delete worker up in the flow

revert changes in inmemory worker start
@shubham3121 shubham3121 force-pushed the shubham/worker-scale-test branch from 739d0b7 to 7e7e8cb Compare September 3, 2024 08:56
@koenvanderveen koenvanderveen merged commit 51c3cf6 into dev Sep 3, 2024
37 checks passed
@koenvanderveen koenvanderveen deleted the shubham/worker-scale-test branch September 3, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants