Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-creating pool with different image spins up with last attached image #9249

Merged
merged 5 commits into from
Sep 3, 2024

Conversation

shubham3121
Copy link
Member

Description

Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

@shubham3121 shubham3121 changed the title Worker pool spins up with same worker image Re-creating pool with different image spins up with same worker image Sep 3, 2024
@shubham3121 shubham3121 changed the title Re-creating pool with different image spins up with same worker image Re-creating pool with different image spins up with last attached image Sep 3, 2024
@shubham3121 shubham3121 requested a review from eelcovdw September 3, 2024 14:23
Copy link
Contributor

@eelcovdw eelcovdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested as well, this works!

@BrendanSchell BrendanSchell merged commit 8f09272 into dev Sep 3, 2024
36 of 37 checks passed
@BrendanSchell BrendanSchell deleted the shubham/pool-different-image branch September 3, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants