front: add, get and delete paced trains #10966

SharglutDev · 2025-02-26T15:13:11Z

See commits (will be merged all together)

Note

PR is now testable !

As some logic from train schedule has been reused for the pace train mode, be sure to check that all previous behavior when paced train mode is off are still working (add/edit/get/delete, duplicate, import/export, nge, drag, selecting/projecting a train, stdcm)

E2E Tests :

part of add : https://github.com/osrd-project/osrd-tests/issues/89 (7-8-10-11 parts)
duplicate/delete : https://github.com/osrd-project/osrd-tests/issues/92

codecov-commenter · 2025-02-26T15:14:52Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 96.69261% with 34 lines in your changes missing coverage. Please review.

Project coverage is 80.90%. Comparing base (ebb9c47) to head (362f2b0).

Files with missing lines	Patch %	Lines
front/src/common/api/osrdEditoastApi.ts	16.00%	21 Missing ⚠️
front/src/reducers/index.ts	12.50%	7 Missing ⚠️
...ents/Timetable/PacedTrain/hooks/useOccurrences.tsx	0.00%	4 Missing ⚠️
front/src/utils/trainId.ts	33.33%	2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev   #10966      +/-   ##
==========================================
+ Coverage   80.86%   80.90%   +0.03%     
==========================================
  Files        1118     1119       +1     
  Lines      112736   113119     +383     
  Branches      759      759              
==========================================
+ Hits        91164    91517     +353     
- Misses      21517    21547      +30     
  Partials       55       55

Flag	Coverage Δ
editoast	`72.61% <ø> (ø)`
front	`89.90% <96.69%> (+0.01%)`	⬆️
gateway	`2.49% <ø> (ø)`
osrdyne	`2.53% <ø> (ø)`
railjson_generator	`87.58% <ø> (ø)`
tests	`88.82% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

emersion

I've looked at the first two commits! Will continue the review later.

...c/modules/trainschedule/components/ManageTrainSchedule/helpers/formatTimetableItemPayload.ts

front/src/modules/trainschedule/components/ManageTrainSchedule/AddTrainScheduleButton.tsx

front/src/modules/trainschedule/components/ManageTrainSchedule/helpers/checkCurrentConfig.ts

front/src/applications/operationalStudies/hooks/useScenarioData.ts

Uriel-Sautron · 2025-03-11T07:39:52Z

front/src/applications/operationalStudies/hooks/useScenarioData.ts

+  const trainScheduleIds = useMemo(
+    () => (fetchedTrainSchedulesResults || []).map((t) => t.id),
+    [fetchedTrainSchedulesResults]
+  );


Suggested change

const trainScheduleIds = useMemo(

() => (fetchedTrainSchedulesResults || []).map((t) => t.id),

[fetchedTrainSchedulesResults]

);

const trainScheduleIds = useMemo(

() => (fetchedTrainSchedulesResults || []).map((trainSchedule) => trainSchedule.id),

[fetchedTrainSchedulesResults]

);

emersion

Here's another round of reviews :P

emersion · 2025-03-11T14:38:19Z

front/src/utils/trainId.ts

@@ -11,6 +17,10 @@ export const isOccurrence = (id: string): id is OccurrenceId => {
 export const isTrainSchedule = (id: string): id is TrainScheduleId =>
  id.startsWith('trainschedule-');

+export const isPacedTrainResultWithPacedTrainId = (
+  timetableITem: TimetableItemWithTimetableId


Typo: "timetableItem"

emersion · 2025-03-11T14:40:27Z

front/src/utils/trainId.ts

@@ -11,6 +17,10 @@ export const isOccurrence = (id: string): id is OccurrenceId => {
 export const isTrainSchedule = (id: string): id is TrainScheduleId =>
  id.startsWith('trainschedule-');

+export const isPacedTrainResultWithPacedTrainId = (
+  timetableITem: TimetableItemWithTimetableId
+): timetableITem is PacedTrainResultWithPacedTrainId => 'paced' in timetableITem;


I'd slightly prefer to check isPacedTrain(timetableItem.id) here

emersion · 2025-03-11T14:44:11Z

front/src/applications/operationalStudies/helpers/formatTimetableItemSummaries.ts

+            duration: Duration.parse(formattedItem.paced.duration),
+            step: Duration.parse(formattedItem.paced.step),
+          },
+        } as PacedTrainWithDetails;


Instead of casting, could we set the type of the variable?

const formattedPacedTrains: PacedTrainWithDetails = …

You're right, done.

emersion · 2025-03-11T14:44:33Z

front/src/applications/operationalStudies/helpers/formatTimetableItemSummaries.ts

+        } as PacedTrainWithDetails;
+        acc[1].push(formattedPacedTrains);
+      } else {
+        acc[0].push(formattedItem as TrainScheduleWithDetails);


Is this cast really necessary?

It's not, you're right.

emersion · 2025-03-11T14:52:32Z

front/src/common/api/osrdEditoastApi.ts

+          const result: PacedTrainResult[] = [];
+          while (!reachEnd) {
+            const promise = dispatch(
+              // TODO : update the endpoint with the proper one when back is ready


Maybe this TODO can be dropped now?

emersion · 2025-03-11T15:13:13Z

front/src/applications/operationalStudies/helpers/formatTimetableItemSummaries.ts

+        ...otherProps,
+      };
+
+      if (isPacedTrainResultWithPacedTrainId(formattedItem)) {


This passes a partially constructed train result to the function. In particular, formattedItem will not yet have a paced field, so the function will always return false here?

Seems safer to check the timetableItem.id instead of operating on an incomplete value.

With the change in this comment, it should be fine I think ?

emersion · 2025-03-11T15:14:25Z

front/src/applications/operationalStudies/helpers/formatTimetableItemSummaries.ts

+  );
+
+  const [trainScheduleWithDetails, pacedTrainWithDetails] = relevantTimetableItems.reduce<
+    [TrainScheduleWithDetails[], PacedTrainWithDetails[]]


This reduce() is tricky to read for me. I would prefer a for loop.

emersion · 2025-03-11T15:15:40Z

front/src/applications/operationalStudies/helpers/formatTimetableItemSummaries.ts

+ * This function formats the timetable items with their simulation summaries.
+ * Mapping the simulation results to the timetable items needs to be done in a second part
+ * because otherwise typescript doesn't understand that a PacedTrainWithDetails will necessarily
+ * be mapped with a PacedTrainId and not a TrainScheduleId (same for TrainScheduleWithDetails)


Hm, curious. The following snippet works for me:

const formatTimetableItemSummaries = ( timetableItemIds: TimetableItemId[], rawSummaries: Map<TimetableItemId, SimulationSummaryResult>, rawTimetableItems: Map<TimetableItemId, TimetableItemWithTimetableId>, rollingStocks: LightRollingStockWithLiveries[] ): Map<TimetableItemId, TimetableItemWithDetails> => { const relevantTimetableItems = compact( timetableItemIds.map((timetableItemId) => rawTimetableItems.get(timetableItemId)) ); const items = relevantTimetableItems.map((timetableItem): TimetableItemWithDetails | null => { const rollingStock = rollingStocks.find((rs) => rs.name === timetableItem.rolling_stock_name); const timetableItemSummary = rawSummaries.get(timetableItem.id); if (!timetableItemSummary) return null; let notHonoredReason: TimetableItemWithDetails['notHonoredReason']; if (timetableItemSummary.status === 'success') { if (isTooFast(timetableItem, timetableItemSummary)) notHonoredReason = 'trainTooFast'; if (isScheduledPointsNotHonored(timetableItem, timetableItemSummary)) notHonoredReason = 'scheduleNotHonored'; } const startTime = new Date(timetableItem.start_time); const otherProps = timetableItemSummary.status === 'success' ? { isValid: true, arrivalTime: new Date(startTime.getTime() + timetableItemSummary.time), duration: new Duration({ milliseconds: timetableItemSummary.time }), pathLength: formatKmValue(timetableItemSummary.length, 'millimeters', 1), mechanicalEnergyConsumed: jouleToKwh(timetableItemSummary.energy_consumption, true), pathItemTimes: { base: timetableItemSummary.path_item_times_base, provisional: timetableItemSummary.path_item_times_provisional, final: timetableItemSummary.path_item_times_final, }, } : { isValid: false, arrivalTime: null, duration: null, pathLength: '', mechanicalEnergyConsumed: 0, invalidReason: timetableItemSummary.status === 'pathfinding_not_found' || timetableItemSummary.status === 'pathfinding_input_error' ? timetableItemSummary.error_type : timetableItemSummary.status, }; const formattedItem = { ...timetableItem, name: timetableItem.train_name, startTime, stopsCount: (timetableItem.schedule?.filter( (step) => step.stop_for && Duration.parse(step.stop_for).ms > 0 ).length ?? 0) + 1, // +1 to take the final stop (destination) into account speedLimitTag: timetableItem.speed_limit_tag ?? null, labels: timetableItem.labels ?? [], rollingStock, scheduledPointsNotHonored: notHonoredReason !== undefined, notHonoredReason, ...otherProps, }; if (isPacedTrainResultWithPacedTrainId(formattedItem)) { return { ...formattedItem, paced: { duration: Duration.parse(formattedItem.paced.duration), step: Duration.parse(formattedItem.paced.step), }, }; } return formattedItem; }); return mapBy(compact(items), 'id'); };

Does this map() approach not work on your machine?

Oh yes you're right. Not sure what I did before that made typescript complain.

emersion · 2025-03-11T15:18:58Z

front/src/applications/operationalStudies/hooks/useLazyLoadTimatableItems.ts

+          [[], []]
+        );
+
+        const rawTrainScheduleSummaries = await postTrainScheduleSimulationSummary({


Nit: would be slightly nicer to fetch these in parallel, without waiting for the train schedule request to complete before sending the paced train request.

const trainSchedulesPromise = postTrainScheduleSimulationSummary(…); const pacedTrainsPromise = postPacedTrainSimulationSummary(…); const rawTrainScheduleSummaries = await trainSchedulesPromise; const rawPacedTrainSummaries = await pacedTrainsPromise;

emersion · 2025-03-11T15:19:27Z

front/src/applications/operationalStudies/hooks/useLazyLoadTimatableItems.ts

+        const rawTrainScheduleSummaries = await postTrainScheduleSimulationSummary({
+          body: {
+            infra_id: _infraId,
+            ids: editoastTrainScheduleIds,


The list can be empty, would be nicer to skip sending an HTTP request when there is nothing to fetch.

front/src/applications/operationalStudies/hooks/useScenarioData.ts

front/src/applications/operationalStudies/hooks/useLazyLoadTimatableItems.ts

Uriel-Sautron · 2025-03-12T14:27:08Z

front/src/applications/operationalStudies/hooks/useScenarioData.ts

      setProjectedTrainsById((prev) => {
        const newProjectedTrainsById = new Map(prev);
-        trainSchedulesToUpsert.forEach((trainSchedule) => {
+        timetableItemsToUpsert.forEach((trainSchedule) => {
          newProjectedTrainsById.delete(trainSchedule.id);
        });
        return newProjectedTrainsById;
      });


setProjectedItemsById((prev) => { const newProjectedItemsById = new Map(prev); timetableItemsToUpsert.forEach((timetableItem) => { newProjectedTrainsById.delete(timetableItem.id); }); return newProjectedItemsById; });

I kept trainSchedule inside for now to remember that we manipulate only train schedule and not paced train. I planned that we would change this when dealing with projection in the related issue. Is that ok for you ?

Maymanaf

Good job !
Left some comments

Maymanaf · 2025-03-12T14:13:24Z

front/tests/pages/operational-studies/scenario-timetable-section.ts

+    await this.verifyOccurrencesCount(totalOccurrences, index);
+
+    await expect(this.hideOccurrencesButton.nth(index)).not.toBeVisible();
+    await expect(pacedTrainItem.locator('.toggle-icon')).toBeVisible();


why not use data-testid

Not sure why but with the data-testid, playwright doesn't find the Locator 🤔

Maymanaf · 2025-03-12T14:15:26Z

front/tests/pages/operational-studies/scenario-timetable-section.ts

+    const formattedDuration = dayjs.duration(pacedTrainDuration).asMinutes();
+    const formattedStep = dayjs.duration(step).asMinutes();


it's better to use the values directly

Maymanaf · 2025-03-12T14:27:29Z

front/tests/pages/operational-studies/scenario-timetable-section.ts

+    await expect(pacedTrainCadenceLocator).toHaveText(
+      `${String.fromCodePoint(0x2014)} ${formattedStep}min`
+    ); // UI format: "- 20min"


you can directly check for 20min

Hmm the displayed text is "- 20min" so I have to deal with the special character no ? Or you want me to test a .toEqual('20min') and pass this hardcoded value when calling the function ?

toHaveText() check if 20min is in the text so the format is not needed
If you keep the format change it to toEqual()

Seems like he wants the exact match :

Maymanaf · 2025-03-12T14:29:10Z

front/tests/pages/operational-studies/scenario-timetable-section.ts

  }

  async clickOnEditTrainSchedule() {
    await this.editTrainScheduleButton.click();
    await this.closeToastNotification();
  }

+  async verifyPacedTrainItemDetails(
+    pacedTrainData: Pick<PacedTrainBase, 'train_name' | 'start_time' | 'labels' | 'paced'>,


you can avoid using the project types and create a new type for the tests

Maymanaf · 2025-03-12T14:34:23Z

front/tests/pages/operational-studies/scenario-timetable-section.ts

+    } = pacedTrainData;
+
+    const pacedTrainItem = this.timetableTrains.nth(pacedTrainIndex);
+    const occurrenceItem = pacedTrainItem.getByTestId('occurrence-item').nth(occurrenceIndex);


Suggested change

const occurrenceItem = pacedTrainItem.getByTestId('occurrence-item').nth(occurrenceIndex);

getOccurrenceItem(occurrenceIndex: number): Locator {

return this.page.getByTestId('occurrence-item').nth(occurrenceIndex);

}

Maymanaf · 2025-03-12T14:49:55Z

front/tests/pages/operational-studies/scenario-timetable-section.ts

+    await occurrenceItem.hover();
+    await expect(occurrenceItem.getByTestId('project-item')).not.toBeVisible();
+    await expect(occurrenceItem.getByTestId('duplicate-item')).not.toBeVisible();
+    await expect(occurrenceItem.getByTestId('edit-item')).not.toBeVisible();
+    await expect(occurrenceItem.getByTestId('delete-item')).not.toBeVisible();


Suggested change

await occurrenceItem.hover();

await expect(occurrenceItem.getByTestId('project-item')).not.toBeVisible();

await expect(occurrenceItem.getByTestId('duplicate-item')).not.toBeVisible();

await expect(occurrenceItem.getByTestId('edit-item')).not.toBeVisible();

await expect(occurrenceItem.getByTestId('delete-item')).not.toBeVisible();

getOccurrenceItem(occurrenceIndex: number): Locator {

return this.page.getByTestId('occurrence-item').nth(occurrenceIndex);

}

async getActionButtonsLocators(occurrenceIndex: number): Record<string, Locator> {

const occurrenceItem = this.getOccurrenceItem(occurrenceIndex);

await occurrenceItem.hover();

return {

projectItem: occurrenceItem.getByTestId('project-item'),

duplicateItem: occurrenceItem.getByTestId('duplicate-item'),

editItem: occurrenceItem.getByTestId('edit-item'),

deleteItem: occurrenceItem.getByTestId('delete-item'),

};

}

async verifyItemsNotVisible(occurrenceIndex: number): Promise<void> {

const actionButtonsLocators = this.getActionButtonsLocators(occurrenceIndex);

await Promise.all(

Object.values(actionButtonsLocators).map(locator => expect(locator).not.toBeVisible())

);

}

getOccurrenceItem(occurrenceIndex: number): Locator {
return this.page.getByTestId('occurrence-item').nth(occurrenceIndex);
}

This won't work because even if they aren't displayed, occurence items still exist in the DOM, so doing page.get... will always return the first group of occurrence. We need to locate them relatively to the current paced train we are testing.

Also regarding this comment, It seems like you want me to fetch occurrenceItem only once but by calling it inside the getActionButtonsLocators method (and the one I'll be creating for name, startTime etc) means we will call it multiple times.

So instead of calling getOccurrenceItem in each method I could pass the current occurrence Locator we are looping on that we would fetch only once at the beginning of verifyOccurrenceDetails.

But if I do that (for example with the name)

async verifyOccurrenceName(currentPacedTrainLocator: Locator, expectedName: string) { const occurrenceNameLocator = currentPacedTrainLocator.locator('.occurrence-item-name'); await expect(occurrenceNameLocator).toHaveText(expectedName); }

I have this eslint warning for each method : Expected 'this' to be used by class async method 'verifyOccurrenceName'.

So best solution seems to be the actual one. Or do you think of something else ?

Maymanaf · 2025-03-12T15:25:30Z

front/tests/assets/constants/operational-studies-const.ts

+    duration: 'PT90M',
+    step: 'PT20M',


It better to hard code the values 90 and 20

Maymanaf · 2025-03-12T15:31:56Z

front/tests/pages/operational-studies/operational-studies-page.ts

+    const formattedTimeRangeDuration = dayjs
+      .duration(DEFAULT_PACED_TRAIN_SETTINGS.paced.duration)
+      .asMinutes()
+      .toString();


Use hardcoded values

Maymanaf · 2025-03-12T15:32:11Z

front/tests/pages/operational-studies/operational-studies-page.ts

+    const formattedCadence = dayjs
+      .duration(DEFAULT_PACED_TRAIN_SETTINGS.paced.step)
+      .asMinutes()
+      .toString();


same use hardcoded values

Maymanaf · 2025-03-12T15:44:48Z

front/tests/pages/operational-studies/scenario-timetable-section.ts

Because multiple locators are scoped within occurrenceItem, you can move all of them in a new page model paced-train-section.ts
and it's best to store them in a reusable function so that you only fetch occurrenceItem once and reuse it

clarani · 2025-03-12T09:41:12Z

front/src/applications/operationalStudies/components/Scenario/ScenarioContent.tsx

@@ -103,10 +103,12 @@ const ScenarioContent = ({
      timeTableId: scenario.timetable_id,
      netzgrafikDto,
      addUpsertedTrainSchedules: (upsertedTrainSchedules: TrainScheduleResultWithTrainId[]) => {
-        upsertTrainSchedules(upsertedTrainSchedules);
+        // TODO Paced trains : update this in https://github.com/OpenRailAssociation/osrd/issues/10612


You can remove the 2 comments, since there is nothing to change here (everything will by in the functions ;) )

Suggested change

// TODO Paced trains : update this in https://github.com/OpenRailAssociation/osrd/issues/10612

clarani · 2025-03-12T09:41:48Z

front/src/applications/operationalStudies/helpers/formatTimetableItemSummaries.ts

+  );
+
+  const [trainScheduleWithDetails, pacedTrainWithDetails] = relevantTimetableItems.reduce<
+    [TrainScheduleWithDetails[], PacedTrainWithDetails[]]


clarani · 2025-03-13T16:52:20Z

front/src/applications/operationalStudies/views/SimulationResults.tsx

@@ -55,6 +59,7 @@ const SimulationResults = ({
  infraId,
  projectionData,
  trainScheduleSummaries,
+  // timetableItemsWithDetails,


Suggested change

// timetableItemsWithDetails,

clarani · 2025-03-13T16:55:32Z

front/src/common/api/osrdEditoastApi.ts

+                { forceRefetch: true, subscribe: false }
+              )
+            );
+            // need to unsubscribe on get call to avoid cache issue


Hm have you unsubscribe here ? Or it is not necessary ?

clarani · 2025-03-13T17:09:04Z

front/src/modules/trainschedule/components/ManageTrainSchedule/AddTrainScheduleButton.tsx

-    if (validTrainConfig) {
-      const { timetableId, firstStartTime, trainCount, trainDelta, trainStep, baseTrainName } =
-        validTrainConfig;
+    const { timetableId, firstStartTime, trainCount, trainDelta, trainStep, baseTrainName } =


You should setIsWorking(true) here

clarani · 2025-03-13T17:09:58Z

front/src/modules/trainschedule/components/ManageTrainSchedule/AddTrainScheduleButton.tsx

+    if (showPacedTrains) {
+      try {


Move the try above the test showPacedTrains

Suggested change

if (showPacedTrains) {

try {

try {

if (showPacedTrains) {

...

This extra useEffect introduced a bug in end to end tests. The only way to reproduce it was to set the train name and start time in less that 500ms (the debounce used for these fields) which the e2e tests do. At this speed, after filling the name, a useEffect is fired after 500ms after to update the store, but since the test is also filling the start time a few ms later, the useEffect was called because nameFromStore had been updated resulting in setting the start time back at its original value. A workaround had been done for tests 011 and 012 to insert the selection of the rolling stock between the name and start time filling. Signed-off-by: SharglutDev <[email protected]>

Signed-off-by: SharglutDev <[email protected]>

…ario

SharglutDev requested a review from a team as a code owner February 26, 2025 15:13

github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 26, 2025

SharglutDev marked this pull request as draft February 26, 2025 15:14

SharglutDev self-assigned this Feb 26, 2025

SharglutDev changed the title ~~front: handle add paced trains~~ add, get and delete paced trains Feb 26, 2025

SharglutDev force-pushed the pfn/front/add-get-delete-paced-trains branch 10 times, most recently from 5cf88dd to 77ebbd0 Compare March 7, 2025 09:21

emersion self-requested a review March 7, 2025 10:25

emersion changed the title ~~add, get and delete paced trains~~ front: add, get and delete paced trains Mar 7, 2025

SharglutDev force-pushed the pfn/front/add-get-delete-paced-trains branch from 77ebbd0 to 9d5a8e6 Compare March 7, 2025 10:37

SharglutDev requested a review from RomainValls March 7, 2025 10:38

emersion reviewed Mar 7, 2025

View reviewed changes

emersion self-requested a review March 7, 2025 16:05

clarani reviewed Mar 7, 2025

View reviewed changes

SharglutDev force-pushed the pfn/front/add-get-delete-paced-trains branch 2 times, most recently from d37c225 to 9f154eb Compare March 10, 2025 12:43

SharglutDev requested a review from Maymanaf March 10, 2025 12:45

SharglutDev force-pushed the pfn/front/add-get-delete-paced-trains branch 3 times, most recently from 46934e7 to b6811f7 Compare March 10, 2025 17:01

Uriel-Sautron reviewed Mar 11, 2025

View reviewed changes

SharglutDev requested a review from clarani March 11, 2025 08:33

emersion reviewed Mar 11, 2025

View reviewed changes

emersion self-requested a review March 11, 2025 15:28

clarani reviewed Mar 12, 2025

View reviewed changes

SharglutDev force-pushed the pfn/front/add-get-delete-paced-trains branch from c1396d9 to d1851e9 Compare March 12, 2025 10:08

Uriel-Sautron reviewed Mar 12, 2025

View reviewed changes

Maymanaf reviewed Mar 12, 2025

View reviewed changes

SharglutDev force-pushed the pfn/front/add-get-delete-paced-trains branch 2 times, most recently from 18590e6 to ce6ee25 Compare March 13, 2025 14:50

clarani reviewed Mar 13, 2025

View reviewed changes

SharglutDev added 7 commits March 14, 2025 18:19

front: convert paced train time range duration and cadence to Duration

406da01

Signed-off-by: SharglutDev <[email protected]>

front: handle add, get, delete and duplicate paced trains

823e214

Signed-off-by: SharglutDev <[email protected]>

fix emersion comments #1

995df0f

fix clarani comments #1

92f0565

fix maymanaf comments #1

32062db

fix error in LazyProject when switching to paced train mode in a scen…

362f2b0

…ario

SharglutDev force-pushed the pfn/front/add-get-delete-paced-trains branch from ce6ee25 to 362f2b0 Compare March 14, 2025 17:19

		const formattedDuration = dayjs.duration(pacedTrainDuration).asMinutes();
		const formattedStep = dayjs.duration(step).asMinutes();

-    const occurrenceItem = pacedTrainItem.getByTestId('occurrence-item').nth(occurrenceIndex);
+  getOccurrenceItem(occurrenceIndex: number): Locator {
+    return this.page.getByTestId('occurrence-item').nth(occurrenceIndex);
+  }

-    await occurrenceItem.hover();
-    await expect(occurrenceItem.getByTestId('project-item')).not.toBeVisible();
-    await expect(occurrenceItem.getByTestId('duplicate-item')).not.toBeVisible();
-    await expect(occurrenceItem.getByTestId('edit-item')).not.toBeVisible();
-    await expect(occurrenceItem.getByTestId('delete-item')).not.toBeVisible();
+  getOccurrenceItem(occurrenceIndex: number): Locator {
+    return this.page.getByTestId('occurrence-item').nth(occurrenceIndex);
+  }
+  async getActionButtonsLocators(occurrenceIndex: number): Record<string, Locator> {
+    const occurrenceItem = this.getOccurrenceItem(occurrenceIndex);
+    await occurrenceItem.hover();
+    return {
+      projectItem: occurrenceItem.getByTestId('project-item'),
+      duplicateItem: occurrenceItem.getByTestId('duplicate-item'),
+      editItem: occurrenceItem.getByTestId('edit-item'),
+      deleteItem: occurrenceItem.getByTestId('delete-item'),
+    };
+  }
+   async verifyItemsNotVisible(occurrenceIndex: number): Promise<void> {
+    const actionButtonsLocators = this.getActionButtonsLocators(occurrenceIndex);
+    await Promise.all(
+      Object.values(actionButtonsLocators).map(locator => expect(locator).not.toBeVisible())
+    );
+  }

front: add, get and delete paced trains #10966

Are you sure you want to change the base?

front: add, get and delete paced trains #10966

Conversation

SharglutDev commented Feb 26, 2025 • edited Loading

codecov-commenter commented Feb 26, 2025 • edited Loading

Codecov Report

emersion left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

emersion left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Maymanaf left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SharglutDev Mar 13, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Maymanaf Mar 12, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SharglutDev commented Feb 26, 2025 •

edited

Loading

codecov-commenter commented Feb 26, 2025 •

edited

Loading

SharglutDev Mar 13, 2025 •

edited

Loading

Maymanaf Mar 12, 2025 •

edited

Loading