Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: doc, scripts: improve openfga management for devs #11167

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

bougue-pe
Copy link
Contributor

fix tests doc on the way

supersedes #11100

fix tests doc on the way

Signed-off-by: Pierre-Etienne Bougué <[email protected]>
@bougue-pe bougue-pe requested review from leovalais and hamz2a March 14, 2025 14:09
@bougue-pe bougue-pe requested review from a team as code owners March 14, 2025 14:09
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Mar 14, 2025
@bougue-pe bougue-pe requested a review from flomonster March 14, 2025 14:09
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.84%. Comparing base (54a1e53) to head (2909623).
Report is 7 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #11167   +/-   ##
=======================================
  Coverage   80.83%   80.84%           
=======================================
  Files        1115     1115           
  Lines      112507   112520   +13     
  Branches      759      759           
=======================================
+ Hits        90945    90964   +19     
+ Misses      21507    21501    -6     
  Partials       55       55           
Flag Coverage Δ
editoast 72.49% <ø> (+0.02%) ⬆️
front 89.89% <ø> (+<0.01%) ⬆️
gateway 2.49% <ø> (ø)
osrdyne 2.53% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 88.82% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@hamz2a hamz2a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need some synchronization with #11115

Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for filling up the holes.

@bougue-pe bougue-pe requested review from Khoyo and removed request for flomonster March 14, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants