Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sc-hsm: add support for opensc-tool --serial #2675

Merged
merged 4 commits into from
Jan 20, 2023

Conversation

frankmorgner
Copy link
Member

fixes #2648

Checklist
  • Documentation is added or updated
  • New files have a LGPL 2.1 license statement
  • PKCS#11 module is tested
  • Windows minidriver is tested
  • macOS tokend is tested

@Jakuje
Copy link
Member

Jakuje commented Jan 19, 2023

What is the significance of the change to MacOSX/OpenSC_binaries.entitlements? The rest looks good, but please, squash it into single commit to avoid fixup commits.

@frankmorgner
Copy link
Member Author

that were accidental changes related to some other issue (removed now)

@Jakuje
Copy link
Member

Jakuje commented Jan 20, 2023

that were accidental changes related to some other issue (removed now)

thanks. Please, squash the commits and then we are good to go.

@frankmorgner frankmorgner merged commit c423672 into OpenSC:master Jan 20, 2023
@frankmorgner
Copy link
Member Author

done using the github merge UI

@frankmorgner frankmorgner deleted the sc-hsm-serial branch January 20, 2023 08:15
@xhanulik xhanulik mentioned this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opensc-tool --serial fails with SC-HSM v4.0 card
2 participants