CMakeLists: add missing include dirs #2202
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-cerny
reviewed
Mar 5, 2025
CMakeLists.txt
Outdated
Comment on lines
575
to
580
| ${LIBXSLT_INCLUDE_DIR} | ||
| ${RPM_INCLUDE_DIRS} | ||
| ${GCRYPT_INCLUDE_DIRS} | ||
| ${BLKID_INCLUDE_DIRS} | ||
| ${POPT_INCLUDE_DIRS} | ||
| ${SELINUX_INCLUDE_DIRS} |
There was a problem hiding this comment.
It probably needs to be wrapped by a condition so that it doesn't add include directories if the libraries aren't found. See the output of the CI on Windows.
chouquette
force-pushed
the
add_missing_includes
branch
from
33e479d to
91c76e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some more include dirs, in case the dependencies aren't all found in the same folder as the other ones