Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prep for new CRAN release #384

Closed
wibeasley opened this issue Feb 22, 2022 · 2 comments
Closed

prep for new CRAN release #384

wibeasley opened this issue Feb 22, 2022 · 2 comments
Assignees
@wibeasley

Comments

@wibeasley
Copy link
Member

wibeasley commented Feb 22, 2022 •
edited
Loading

There are some small updates in the GitHub version that should be pushed to CRAN. Plus in the past three weeks, there have been three great PRs I'm excited about
@wibeasley wibeasley self-assigned this Feb 22, 2022
wibeasley added a commit that referenced this issue Feb 22, 2022
@wibeasley
newer test environments
68398ab 
ref #384
wibeasley added a commit that referenced this issue Feb 22, 2022
@wibeasley
update urls
dd7e703 
with `urlchecker::url_check()`

ref #384
wibeasley added a commit that referenced this issue Aug 10, 2022
@wibeasley
fix urls
2cb46b8 
ref #384
wibeasley added a commit that referenced this issue Aug 10, 2022
@wibeasley
fix new rules in goodpractice
a63baea 
and one more url

ref #384
wibeasley added a commit that referenced this issue Aug 10, 2022
@wibeasley
bump version; update cran-comments explanation
585fa59 
ref #384
wibeasley added a commit that referenced this issue Aug 10, 2022
@wibeasley
remove rproj settings
677c2ba 
I guess RStudio removed it

ref #384
wibeasley added a commit that referenced this issue Aug 10, 2022
@wibeasley
cran-comments
6f3b0e4 
ref #384
wibeasley added a commit that referenced this issue Aug 10, 2022
@wibeasley
address nested <em> blocks
ef0c4c3 
fixes note "Found the following HTML validation problems:
redcap_read_oneshot.html:218:1: Warning: nested emphasis <em>"

ref #384
wibeasley added a commit that referenced this issue Aug 10, 2022
@wibeasley
update link to winbuilder
f5f520c 
ref #384
wibeasley added a commit that referenced this issue Aug 10, 2022
@wibeasley
update news version
f78db7f 
ref #384
wibeasley added a commit that referenced this issue Aug 10, 2022
@wibeasley
cran-submission
ded2813 
ref #384
@wibeasley
Copy link
Member Author

Something on the old version on cran became unhappy after we upgraded our server. Basically it was correctly catching an error message, but the error message was slightly different, so it looked a failure to CRAN. There are a bunch of new minor features/functions, but from CRAN's perspective, the biggest difference is that no REDCap server is called. There were a few tests that weren't skipped.

     == Failed tests ================================================================
     -- Failure (test-read-errors.R:39:3): One Shot: Bad Uri -wrong address ---------
     returned_object$raw_text (`actual`) not equal to `expected_message` (`expected`).
    
     lines(actual) vs lines(expected)
     - "<!DOCTYPE HTML PUBLIC \"-//IETF//DTD HTML 2.0//EN\">"
     - "<html><head>"
     - "<title>404 Not Found</title>"
     - "</head><body>"
     - "<h1>Not Found</h1>"
     - "<p>The requested URL was not found on this server.</p>"
     - "</body></html>"
     + "<!DOCTYPE html PUBLIC \"-//W3C//DTD XHTML 1.0 Strict//EN\" \"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd\">"
     + "<html xmlns=\"http://www.w3.org/1999/xhtml\">"
     + "<head>"
     + "<meta http-equiv=\"Content-Type\" content=\"text/html; charset=iso-8859-1\"/>"
     + "<title>404 - File or directory not found.</title>"
     + "<style type=\"text/css\">"
     + "<!--"
     + "body{margin:0;font-size:.7em;font-family:Verdana, Arial, Helvetica, sans-serif;background:#EEEEEE;}"
     + "fieldset{padding:0 15px 10px 15px;} "
     + "h1{font-size:2.4em;margin:0;color:#FFF;}"
     and 20 more ...
    
     [ FAIL 1 | WARN 0 | SKIP 109 | PASS 171 ]
     Error: Test failures

@wibeasley
Copy link
Member Author

Just accepted by CRAN. The only notes were declared in cran-comments.md

Dear maintainer,

thanks, package REDCapR_1.1.0.tar.gz is on its way to CRAN.

Best regards,
CRAN teams' auto-check service

Package check result: NOTE

Check: CRAN incoming feasibility, Result: NOTE
  Maintainer: ‘Will Beasley <[email protected]>’
  
  Found the following (possibly) invalid URLs:
    URL: https://atom.io/
      From: inst/doc/TroubleshootingApiCalls.html
      Status: 500
      Message: Internal Server Error
    URL: https://grantome.com/grant/NIH/P01-AG043362
      From: README.md
      Status: Error
      Message: server certificate verification failed. CAfile: none CRLfile: none
        	(Status without verification: OK)
    URL: https://grantome.com/grant/NIH/P01-AG043362-05
      From: man/REDCapR-package.Rd
      Status: Error
      Message: server certificate verification failed. CAfile: none CRLfile: none
        	(Status without verification: OK)
    URL: https://grantome.com/grant/NIH/U54-GM104938
      From: man/REDCapR-package.Rd
            README.md
      Status: Error
      Message: server certificate verification failed. CAfile: none CRLfile: none
        	(Status without verification: OK)
    URL: https://taggs.hhs.gov/Detail/AwardDetail?arg_AwardNum=U54GM104938&arg_ProgOfficeCode=127
      From: inst/doc/workflow-read.html
            README.md
      Status: Error
      Message: server certificate verification failed. CAfile: none CRLfile: none
        	(Status without verification: OK)
    URL: https://www.researchgate.net/profile/William-Beasley-5
      From: README.md
      Status: 403
      Message: Forbidden

No changes to worse in reverse depends.

wibeasley added a commit that referenced this issue Aug 10, 2022
@wibeasley
bump to dev version number after cran release
c54b4da 
ref #384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wibeasley wibeasley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wibeasley