Disable spline potential #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #182 +/- ##
==========================================
- Coverage 92.83% 91.86% -0.98%
==========================================
Files 47 47
Lines 6785 6748 -37
Branches 762 758 -4
==========================================
- Hits 6299 6199 -100
- Misses 474 537 +63
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JanosJiri
approved these changes
Oct 26, 2024
| @@ -1,8 +1,10 @@ | |||
| ! 1D user-defined numerical potential with cubic splines | |||
| ! Original code taken from QDYN | |||
| ! https://github.com/PHOTOX/qdyn | |||
There was a problem hiding this comment.
Just a comment, the cubic splines are not implemented in QDyn anymore. It's probably still in some of the old commits.
There was a problem hiding this comment.
Good to know. What do you use instead?
There was a problem hiding this comment.
I use Python scripts to prepare the potential.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ABIN has an implementation of a numerical 1D potential on top of user-defined grid of points (
pot="_splined_grid_"). We use cubic splines to interpolate between the points.Unfortunately, the cubic spline routines (originally taken from QDYN) are from Numerical recipes and we don't have license for them. Until we implement our own cubic spline, this commit remove the NR routines and disables the
_spline_potential and associated tests.