Add MAXIFS, MINIFS, COUNTIFS and Remove MINIF, MAXIF

[zdenekdrahos]

This is:

- [x] a bug report
- [x] a feature request
- [ ] **not** a usage question (ask them on https://stackoverflow.com/questions/tagged/phpspreadsheet or https://gitter.im/PHPOffice/PhpSpreadsheet)

Related issues: #915, #683

What is the expected behavior?

• MINIFS, MAXIFS, COUNTIFS works
• MINIF, MAXIF are deleted (not supported in spreadsheets) or fixed

{
    "MINIFS": "C5[5] == [5]",
    "MAXIFS": "C6[12] == [12]",
    "MINIF": "D5[5] == [5]",
    "MAXIF": "D6[12] == [12]",
    "SUMIFS": "C7[17] == [17]",
    "SUMIF": "D7[17] == [17]",
    "COUNTIFS": "C8[2] == [2]",
    "COUNTIF": "D8[2] == [2]",
}

What is the current behavior?

• MINIFS, MAXIFS causes an exception Formula Error: Unexpected ,]
• COUNTIFS has no result
• MINIF, MAXIF has zero result

{
    "MINIFS": "C5[Worksheet!C5 -> Formula Error: Unexpected ,] != [5]",
    "MAXIFS": "C6[Worksheet!C6 -> Formula Error: Unexpected ,] != [12]",
    "MINIF": "D5[0] != [5]",
    "MAXIF": "D6[0] != [12]",
    "SUMIFS": "C7[17] == [17]",
    "SUMIF": "D7[17] == [17]",
    "COUNTIFS": "C8[] != [2]",
    "COUNTIF": "D8[2] == [2]",
}

What are the steps to reproduce?

Please provide a Minimal, Complete, and Verifiable example of code that exhibits the issue without relying on an external Excel file or a web server:

<?php

require 'vendor/autoload.php';

// Create new Spreadsheet object
$spreadsheet = new \PhpOffice\PhpSpreadsheet\Spreadsheet();

// code that show the issue
$spreadsheet->getActiveSheet()
    ->setCellValue('B1', "5")
    ->setCellValue('B2', "8")
    ->setCellValue('B3', "12")
    ->setCellValue('B4', "15")
    ->setCellValue('C1', 0)
    ->setCellValue('C2', 0.2)
    ->setCellValue('C3', 0)
    ->setCellValue('C4', 0.2);

$spreadsheet->getActiveSheet()
    ->setCellValue('C5', "=MINIFS(B1:B4, C1:C4, 0)")
    ->setCellValue('D5', "=MINIF(C1:C4, 0, B1:B4)")
    ->setCellValue('C6', "=MAXIFS(B1:B4, C1:C4, 0)")
    ->setCellValue('D6', "=MAXIF(C1:C4, 0, B1:B4)")
    ->setCellValue('C7', "=SUMIFS(B1:B4, C1:C4, 0)")
    ->setCellValue('D7', "=SUMIF(C1:C4, 0, B1:B4)")
    ->setCellValue('C8', "=COUNTIFS(C1:C4, 0)")
    ->setCellValue('D8', "=COUNTIF(C1:C4, 0)");

$testFile = __DIR__ . '/minifs-bug.xls';
PhpOffice\PhpSpreadsheet\IOFactory::createWriter($spreadsheet, 'Xlsx')
    ->setPreCalculateFormulas(false) // hotfix for saving file with not implemented formula
    ->save($testFile);

// https://phpspreadsheet.readthedocs.io/en/latest/references/function-list-by-name/
echo json_encode(
    [
        // 1) Not Implemented
        'MINIFS' => compareCellResult($spreadsheet, 'C5', min([5, 12])),
        'MAXIFS' => compareCellResult($spreadsheet, 'C6', max([5, 12])),
        // Implemented in phpspreadsheet, not supported in Libreoffice/GoogleSpreadsheet/Excel
        'MINIF' => compareCellResult($spreadsheet, 'D5', min([5, 12])),
        'MAXIF' => compareCellResult($spreadsheet, 'D6', max([5, 12])),
        // 2) Implemented
        'SUMIFS' => compareCellResult($spreadsheet, 'C7', array_sum([5, 12])), // OK
        'SUMIF' => compareCellResult($spreadsheet, 'D7', array_sum([5, 12])), // OK
        'COUNTIFS' => compareCellResult($spreadsheet, 'C8', count([5, 12])), // Not yet Implemented
        'COUNTIF' => compareCellResult($spreadsheet, 'D8', count([5, 12])), // OK
        'file' => $testFile
    ],
    JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES
) . "\n";

function compareCellResult($spreadsheet, $cell, $expectedResult)
{
    try {
        $cellValue = $spreadsheet->getActiveSheet()->getCell($cell)->getCalculatedValue();
    } catch (\Exception $e) {
        $cellValue = $e->getMessage();
    }
    $result = $cellValue == $expectedResult ? '==' : '!=';
    return "{$cell}[{$cellValue}] {$result} [{$expectedResult}]";
}

Which versions of PhpSpreadsheet and PHP are affected?

Tested on PhpSpreadsheet 1.7.0 and PHP 7.0.