Cloning worksheet makes corrupted Xlsx

[marcopaggioro]

This is:

- [X] a bug report
- [ ] a feature request
- [ ] **not** a usage question (ask them on https://stackoverflow.com/questions/tagged/phpspreadsheet or https://gitter.im/PHPOffice/PhpSpreadsheet)

What is the expected behavior?

With old versions of PHPSpreadsheet I was able to clone worksheets (as in the tutorial) and I was able to edit it correctly. For example if I opened an Xlsx file with one template worksheet I was able to clone it N times and every worksheet had different values.

What is the current behavior?

Now, if I try to clone a worksheet and save the Xlsx file it results corrupted.

What are the steps to reproduce?

Example file:
ReportStructure.xlsx

Code:

<?php

require __DIR__ . '/vendor/autoload.php';

use PhpOffice\PhpSpreadsheet\IOFactory;
use PhpOffice\PhpSpreadsheet\Shared\Date;
use PhpOffice\PhpSpreadsheet\Spreadsheet;
use PhpOffice\PhpSpreadsheet\Writer\Xlsx;

try {
    $spreadsheet = IOFactory::load("./ReportStructure.xlsx");
    $clonedSheet = clone $spreadsheet->getActiveSheet();
    $clonedSheet->setTitle("Example");
    $spreadsheet->addSheet($clonedSheet);
    
    $writer = new Xlsx($spreadsheet);
    $writer->save("Report.xlsx");
} catch (Exception $exception) {
    echo $exception;
}

Screen:

If I press "Si" (Yes), Excel crash

Which versions of PhpSpreadsheet and PHP are affected?

SpreadSheet: 5c18bb5 (1.13)
PHP: 7.3

[konovalovk]

Appeared in v 1.13. Previous release is not affected.

[oleibman]

This has to do with the change to ZipStream. Before and after, because of the clone, PhpSpreadsheet tries to write printerSettings1.bin to xl/printerSettings/. With the PHP Zip class, only one copy of this file is retained. But, with ZipStream, both copies are retained (I didn't even know that was possible), and that is the problem that Excel is having. I am not familiar with ZipStream,
and do not know how to fix this issue, but hopefully someone who is knowledgeable enough will see this comment.

[oleibman]

Omitted one word above.
... tries twice to write printerSettings1.bin ...

[agwidarsito]

Strange that two copies in the same path, with the same name, are being retained. Is that even a valid ZIP?

[kimbarcelona01]

Made this work by downgrading to v.1.11 for now. Lets wait for fixed release

[marcopaggioro]

@kimbarcelona01 Unfortunately, version 1.11 as well as 1.12 have a bug regarding the Drawer which is fixed in 1.13

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this is still an issue for you, please try to help by debugging it further and sharing your results.
Thank you for your contributions.

[oleibman]

Fixed by PR #1530 in June 2020.