Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viewport Implementation #3565

Closed
kissadamfkut opened this issue May 13, 2023 · 1 comment · Fixed by #3623
Closed

Viewport Implementation #3565

kissadamfkut opened this issue May 13, 2023 · 1 comment · Fixed by #3623

Comments

@kissadamfkut
Copy link

This is:

- [ ] a bug report
- [X] a feature request
- [X] **not** a usage question

Solution given in: 7f77c0a

Can I open a pull request?

What is the expected behavior?

If an attribute is set to a html writer, then the given html should fit the width of the browser.

What is the current behavior?

Nothing.
@MarkBaker
Copy link
Member

Certainly you can submit a PR

Have a read of the contributing guidelines, and please remember to include unit tests as part of the submission

oleibman added a commit to oleibman/PhpSpreadsheet that referenced this issue Jun 25, 2023
@oleibman
Permit Meta Viewport in Html
18425c5 
Fix PHPOffice#3565. Requester suggested adding viewport as a property of Html Writer. I think it would fit better as a Document Property, so that it can be both read and written, just like other meta properties, making it easier to load an Html spreadsheet and save it as a new one preserving this property. It is an open question whether we should try to preserve this property when writing to other spreadsheet types, e.g. as a custom property for Xlsx. For now, I am not attempting that. Requester also suggested this as a boolean property, but there are other parameters and different values that might be used for viewport. So I am defining it as a string property, with a constant SUGGESTED_VIEWPORT that can be used for requester's use case.
@oleibman oleibman mentioned this issue Jun 25, 2023
Merged
11 tasks
oleibman added a commit that referenced this issue Jun 30, 2023
@oleibman
Permit Meta Viewport in Html (#3623)
4363de1 
Fix #3565. Requester suggested adding viewport as a property of Html Writer. I think it would fit better as a Document Property, so that it can be both read and written, just like other meta properties, making it easier to load an Html spreadsheet and save it as a new one preserving this property. It is an open question whether we should try to preserve this property when writing to other spreadsheet types, e.g. as a custom property for Xlsx. For now, I am not attempting that. Requester also suggested this as a boolean property, but there are other parameters and different values that might be used for viewport. So I am defining it as a string property, with a constant SUGGESTED_VIEWPORT that can be used for requester's use case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Permit Meta Viewport in Html oleibman/PhpSpreadsheet
2 participants
@MarkBaker @kissadamfkut