Additional Coverage for Reader Xls #3340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More than 750 lines are newly covered, increasing overall coverage on my machine from 91.14% to 93.09%.
oleibman
added a commit
to oleibman/PhpSpreadsheet
that referenced
this pull request
Feb 16, 2023
PR PHPOffice#3340 increased coverage in Reader Xls for most functions. Some of the omissions from that PR (see below) were intended from the start. However, the set of (BINOMDIST, EXPONDIST, GAMMADIST, NORMDIST, POISSON, WEIBULL, and FIXED) were not intended to be omitted; they just did not seem to work. Having had time to research, it appears that the problem is not those functions themselves, but rather the use of Boolean constants as function arguments (see issue PHPOffice#3369). Knowing that, it is possible to add those missing functions back in, just taking care to use `0` or `1` or `TRUE()` or `FALSE()` rather than boolean constants as arguments. No update to source or test code; just adding a few new cells to an Xls spreadsheet. Functions still omitted because they return array results: - GROWTH - LINEST - LOGEST - MINVERSE - MMULT - TRANSPOSE - TREND Functions still omitted because they are not implemented in PhpSpreadsheet: - BAHTTEXT - CELL - FREQUENCY - GETPIVOTDATA
11 tasks
oleibman
added a commit
that referenced
this pull request
Feb 16, 2023
PR #3340 increased coverage in Reader Xls for most functions. Some of the omissions from that PR (see below) were intended from the start. However, the set of (BINOMDIST, EXPONDIST, GAMMADIST, NORMDIST, POISSON, WEIBULL, and FIXED) were not intended to be omitted; they just did not seem to work. Having had time to research, it appears that the problem is not those functions themselves, but rather the use of Boolean constants as function arguments (see issue #3369). Knowing that, it is possible to add those missing functions back in, just taking care to use `0` or `1` or `TRUE()` or `FALSE()` rather than boolean constants as arguments. No update to source or test code; just adding a few new cells to an Xls spreadsheet. Functions still omitted because they return array results: - GROWTH - LINEST - LOGEST - MINVERSE - MMULT - TRANSPOSE - TREND Functions still omitted because they are not implemented in PhpSpreadsheet: - BAHTTEXT - CELL - FREQUENCY - GETPIVOTDATA
oleibman
added a commit
to oleibman/PhpSpreadsheet
that referenced
this pull request
Feb 20, 2023
Finish the work started in PR PHPOffice#3371 and PR PHPOffice#3340.
11 tasks
oleibman
added a commit
that referenced
this pull request
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More than 750 lines are newly covered, increasing overall coverage on my machine from 91.14% to 93.09%.
This is:
Checklist:
Why this change is needed?
Provide an explanation of why this change is needed, with links to any Issues (if appropriate).
If this is a bugfix or a new feature, and there are no existing Issues, then please also create an issue that will make it easier to track progress with this PR.