Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide an Ignore/Return Hidden rows/columns option to the toArray() methods #3494

Merged
merged 5 commits into from
Apr 1, 2023
Merged

Provide an Ignore/Return Hidden rows/columns option to the toArray() methods #3494

merged 5 commits into from
Apr 1, 2023

Conversation

MarkBaker
Copy link
Member

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Why this change is needed?

New Feature as per Discussion #3490... though I've had no response there to this idea for improvement

@MarkBaker MarkBaker marked this pull request as ready for review April 1, 2023 20:22
@MarkBaker MarkBaker merged commit 378d46b into master Apr 1, 2023
@MarkBaker MarkBaker deleted the Worksheet-toArray_Ignore-Hidden-Rows-Columns-Option branch April 6, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MarkBaker