Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning when reading xlsx without styles #631

Merged
merged 3 commits into from
Aug 19, 2018
Merged

Fix warning when reading xlsx without styles #631

merged 3 commits into from
Aug 19, 2018

Conversation

AegirLeet
Copy link
Contributor

@AegirLeet AegirLeet commented Aug 9, 2018

This is:

- [x] a bugfix
- [ ] a new feature

Checklist:

Why this change is needed?

This is basically the same problem as PHPOffice/PHPExcel#1134.
I ran into an .xlsx file which, apparently, doesn't contain styles - this results in a PHP Warning: Invalid argument supplied for foreach() in .../vendor/phpoffice/phpspreadsheet/src/PhpSpreadsheet/Reader/Xlsx.php on line 646 when trying to read it with PhpSpreadsheet.

@PowerKiKi PowerKiKi merged commit bebfb1e into PHPOffice:develop Aug 19, 2018
@PowerKiKi
Copy link
Member

Thanks !

Dfred pushed a commit to Dfred/PhpSpreadsheet that referenced this pull request Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants